Merge pull request #99 from ekohl/fix-rubocop

Rename Naming/PredicateName to PreficatePrefix

Author: bastelfreak

.rubocop.yml

@@ -161,7 +161,7 @@ Naming/MethodName:
 Naming/MethodParameterName:
   Enabled: false
 
-Naming/PredicateName:
+Naming/PredicatePrefix:
   ForbiddenPrefixes: []
 
 Naming/RescuedExceptionsVariableName:

lib/puppet/feature/base.rb

@@ -58,7 +58,7 @@ module WindowsSymlink
       require 'ffi'
       extend FFI::Library
 
-      def self.is_implemented # rubocop:disable Naming/PredicateName
+      def self.is_implemented # rubocop:disable Naming/PredicatePrefix
         ffi_lib :kernel32
         attach_function :CreateSymbolicLinkW, [:lpwstr, :lpwstr, :dword], :boolean
 

lib/puppet/functions/defined.rb

@@ -107,7 +107,7 @@
     required_repeated_param 'Variant[String, Type[CatalogEntry], Type[Type[CatalogEntry]]]', :vals
   end
 
-  def is_defined(scope, *vals) # rubocop:disable Naming/PredicateName
+  def is_defined(scope, *vals) # rubocop:disable Naming/PredicatePrefix
     vals.any? do |val|
       case val
       when String

lib/puppet/parameter.rb

@@ -93,15 +93,15 @@ def defaultto(value = nil, &block)
       end
     end
 
-    # rubocop:disable Naming/PredicateName
+    # rubocop:disable Naming/PredicatePrefix
     def sensitive(value = nil, &block)
       if block
         define_method(:is_sensitive, &block)
       else
         define_method(:is_sensitive) do value end
       end
     end
-    # rubocop:enable Naming/PredicateName
+    # rubocop:enable Naming/PredicatePrefix
 
     # Produces a documentation string.
     # If an enumeration of _valid values_ has been defined, it is appended to the documentation

lib/puppet/property.rb

@@ -403,7 +403,7 @@ def property_matches?(current, desired)
   # are not already in suitable form.
   # @param value [Object] the value to format as a string
   # @return [String] a pretty printing string
-  def is_to_s(value) # rubocop:disable Naming/PredicateName
+  def is_to_s(value) # rubocop:disable Naming/PredicatePrefix
     self.class.format_value_for_display(value)
   end
 

lib/puppet/property/keyvalue.rb

@@ -34,7 +34,7 @@ def should_to_s(should_value)
         hash_to_key_value_s(should_value)
       end
 
-      def is_to_s(current_value) # rubocop:disable Naming/PredicateName
+      def is_to_s(current_value) # rubocop:disable Naming/PredicatePrefix
         hash_to_key_value_s(current_value)
       end
 

lib/puppet/property/list.rb

@@ -8,7 +8,7 @@ class Property
     # For an ordered list see {Puppet::Property::OrderedList}.
     #
     class List < Property
-      def is_to_s(currentvalue) # rubocop:disable Naming/PredicateName
+      def is_to_s(currentvalue) # rubocop:disable Naming/PredicatePrefix
         currentvalue == :absent ? super(currentvalue) : currentvalue.join(delimiter)
       end
 

lib/puppet/provider.rb

@@ -199,7 +199,7 @@ def self.optional_commands(hash)
   # @note the name ´has_command´ looks odd in an API context, but makes more sense when seen in the internal
   #   DSL context where a Provider is declaratively defined.
   # @api public
-  # rubocop:disable Naming/PredicateName
+  # rubocop:disable Naming/PredicatePrefix
   def self.has_command(name, path, &block)
     name = name.intern
     command = CommandDefiner.define(name, path, self, &block)
@@ -211,7 +211,7 @@ def self.has_command(name, path, &block)
       return command.execute(*args)
     end
   end
-  # rubocop:enable Naming/PredicateName
+  # rubocop:enable Naming/PredicatePrefix
 
   # Internal helper class when creating commands - undocumented.
   # @api private
@@ -232,7 +232,7 @@ def initialize(name, path, confiner)
       @custom_environment = {}
     end
 
-    def is_optional # rubocop:disable Naming/PredicateName
+    def is_optional # rubocop:disable Naming/PredicatePrefix
       @optional = true
     end
 

lib/puppet/type/file/group.rb

@@ -39,7 +39,7 @@ def insync?(current)
     end
 
     # We want to print names, not numbers
-    def is_to_s(currentvalue) # rubocop:disable Naming/PredicateName
+    def is_to_s(currentvalue) # rubocop:disable Naming/PredicatePrefix
       super(provider.gid2name(currentvalue) || currentvalue)
     end
 

lib/puppet/type/file/mode.rb

@@ -179,7 +179,7 @@ def should_to_s(should_value)
       "'#{should_value.rjust(4, '0')}'"
     end
 
-    def is_to_s(currentvalue) # rubocop:disable Naming/PredicateName
+    def is_to_s(currentvalue) # rubocop:disable Naming/PredicatePrefix
       if currentvalue == :absent
         # This can occur during audits---if a file is transitioning from
         # present to absent the mode will have a value of `:absent`.