Skip to content

Commit 712ff61

Browse files
authored
Merge pull request #74 from bastelfreak/cache
CI: Use builtin option to install gems & fix rubocop config
2 parents 6802054 + eff73cc commit 712ff61

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

.github/workflows/checks.yaml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ on:
1010
permissions:
1111
contents: read
1212

13+
env:
14+
BUNDLE_WITHOUT: packaging:documentation
15+
1316
jobs:
1417
checks:
1518
name: ${{ matrix.cfg.check }}
@@ -28,12 +31,7 @@ jobs:
2831
uses: ruby/setup-ruby@v1
2932
with:
3033
ruby-version: ${{ matrix.cfg.ruby }}
31-
32-
- name: Update rubygems and install gems
33-
run: |
34-
gem update --system --silent --no-document
35-
bundle config set without packaging documentation
36-
bundle install --jobs 4 --retry 3
34+
bundler-cache: true
3735

3836
- name: Run ${{ matrix.cfg.check }} check
3937
run: bundle exec rake ${{ matrix.cfg.check }}

.rubocop.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ plugins:
77
- rubocop-rake
88
- rubocop-rspec
99

10+
# without excluding the vendor dirs below, rubocop will load all rubocop config files from installed gems ¯\_(ツ)_/¯
1011
AllCops:
1112
TargetRubyVersion: 3.1
1213
Include:
@@ -21,6 +22,8 @@ AllCops:
2122
- 'lib/puppet/vendor/**/*'
2223
- 'lib/puppet/pops/model/ast.rb'
2324
- 'lib/puppet/pops/parser/eparser.rb'
25+
- 'vendor/**/*'
26+
- '.vendor/**/*'
2427

2528
# The formatting of defaults is unusual, so let's skip layout cops.
2629
Layout:

0 commit comments

Comments
 (0)