rubocop: use default rake task

Author: bastelfreak

.github/workflows/checks.yaml

@@ -15,16 +15,19 @@ jobs:
     name: Rake Checks
     runs-on: ubuntu-24.04
     steps:
+      # needs fetch-depth because the packaging dem reads old git tags
       - name: Checkout current PR
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
       - name: Install Ruby version 3.3
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: 3.3
           bundler-cache: true
       - name: Validate code
         run: |
-          bundle exec rake rubocop --trace
+          bundle exec rake rubocop
           bundle exec rake -T | grep vox:build
           bundle exec rake -T | grep vox:promote
           bundle exec rake -T | grep vox:tag

.rubocop.yml

@@ -8,8 +8,12 @@ AllCops:
     - 'resources/**/*.rb'
     - 'ext/**/*'
     - 'vendor/**/*'
+    - '.vendor/**/*'
     - 'bundle/**/*'
 
+plugins:
+  - rubocop-rake
+
 Layout/ArgumentAlignment:
   Enabled: false
 

Gemfile

@@ -17,5 +17,6 @@ gem 'rake'
 gem 'json'
 gem 'octokit'
 gem 'rubocop', "~> 1.22"
+gem 'rubocop-rake'
 
 eval_gemfile("#{__FILE__}.local") if File.exist?("#{__FILE__}.local")

Rakefile

@@ -39,12 +39,12 @@ load './ext/release-lead.rake'
 
 Pkg::Util::RakeUtils.load_packaging_tasks
 
-desc 'run static analysis with rubocop'
-task(:rubocop) do
-  require 'rubocop'
-  cli = RuboCop::CLI.new
-  exit_code = cli.run(%w(--display-cop-names --format simple))
-  raise "RuboCop detected offenses" if exit_code != 0
+require 'rubocop/rake_task'
+RuboCop::RakeTask.new(:rubocop) do |task|
+  # These make the rubocop experience maybe slightly less terrible
+  task.options = ['--display-cop-names', '--display-style-guide', '--extra-details']
+  # Use Rubocop's Github Actions formatter if possible
+  task.formatters << 'github' if ENV['GITHUB_ACTIONS'] == 'true'
 end
 
 desc "verify that commit messages match CONTRIBUTING.md requirements"