Skip to content

Commit 3e81a8a

Browse files
committed
Make passing invalid options to install.rb fatal
In b909b67 the --[no-]prereq-checks option was dropped. The error was printed, but then continued to execute and it ignored all passed options. That caused a regression in 8.21.0. It now catches the error and exits with a non-zero exit code, forcing the packager to deal with it.
1 parent 77cc7a4 commit 3e81a8a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

install.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,9 @@ def prepare_installation
159159
end
160160

161161
opts.parse!
162+
rescue OptionParser::InvalidOption => e
163+
$stderr.puts e
164+
exit 1
162165
end
163166

164167
# Mac OS X 10.5 and higher declare bindir

0 commit comments

Comments
 (0)