-
Notifications
You must be signed in to change notification settings - Fork 130
Add new message for BoundingBox sub-sections #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a042d7a
Add new message for BoundingBox sub-sections
ndunningbmw 41bb5d0
Fix typos, extend comment
ndunningbmw e0b7c21
Add comments and update formatting
ndunningbmw 60f0e59
Remove extra blank line
ndunningbmw f9bf13c
Merge branch 'OpenSimulationInterface:master' into master
ndunningbmw a9e947b
Add new message for BoundingBox sub-sections
ndunningbmw 2b65b9b
Fix typos, extend comment
ndunningbmw aebcff7
Add comments and update formatting
ndunningbmw 77e8a19
Remove extra blank line
ndunningbmw 0cfbf75
Build/master branch naming (#672)
philipwindecker b0a1413
Never trigger antora builds for PRs from forks (#686)
pmai 5e4307e
Fix traffic sign variability attribute description
thomassedlmayer f1a3d77
Merge branch 'master' of https://github.com/ndunningbmw/open-simulati…
ndunningbmw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -387,6 +387,68 @@ message LogicalLaneAssignment | |
| optional double angle_to_lane = 4; | ||
| } | ||
|
|
||
| // | ||
| // Note: The parent bounding box of the base object should not be setup as a BoundingBox, use the dimension field of the message for this (make this clear in a support image) | ||
| message BoundingBox | ||
| { | ||
| // The 3D dimensions of the bounding box. | ||
| // | ||
| optional Dimension3d dimension = 1; | ||
|
|
||
| // The 3D position of the bounding box. | ||
| // | ||
| // TODO: Make sure this is clear that the position is "absolute" to the GT frame | ||
| optional Vector3d position = 2; | ||
|
|
||
| // TODO: make sure this is clear, the parent frame is intended to mean the GT frame for this use-case | ||
| // The relative orientation of the bounding box w.r.t. its parent | ||
| // frame, noted in the parent frame. The orientation becomes global/absolute | ||
| // if the parent frame is inertial (all parent frames up to ground truth). | ||
| // | ||
| // \f$ Origin_{\text{base stationary entity}} := | ||
| // Rotation_{yaw,pitch,roll}( \f$ \c #orientation \f$ )* | ||
| // (Origin_{\text{parent coord system}} - | ||
| // \f$ \c #position \f$ )\f$ | ||
| // | ||
| // | ||
| optional Orientation3d orientation = 3; | ||
|
|
||
| // The type of object contained in the bounding box. | ||
| // | ||
| optional Type contained_object_type = 4; | ||
|
|
||
| // Opaque reference of an associated 3D model of the bounding box. | ||
| // | ||
| // \note It is implementation-specific how model_references are resolved to | ||
| // 3d models. | ||
| // | ||
| // TODO: Do we want to offer general guidelines regarding the origin of the 3d model vs the BoundingBox pos, Object pos, etc. | ||
| // | ||
| optional string model_reference = 5; | ||
|
|
||
| // TODO: See if this can be aligned to the way other OSI enums are named | ||
| enum Type | ||
| { | ||
| // General stuff | ||
| TYPE_UNKNOWN = 0; | ||
| TYPE_OTHER = 1; | ||
|
|
||
| // Car stuff | ||
| TYPE_CHASSIS = 2; | ||
| TYPE_DOOR = 3; | ||
| TYPE_SIDEMIRROR = 4; | ||
| TYPE_CARGO = 5; | ||
|
|
||
| // People/animal stuff | ||
| // TODO: Those interested in pedestrian modeling need to add their input here | ||
| TYPE_TORSO = 6; | ||
| TYPE_LIMB = 7; | ||
| TYPE_HEAD = 8; | ||
|
|
||
| // TODO: Do we want to handle data for BaseStationary here as well? What problems would having this solve? | ||
|
||
| } | ||
| } | ||
|
|
||
| // | ||
| // \brief The base attributes of a stationary object or entity. | ||
| // | ||
|
|
@@ -569,6 +631,13 @@ message BaseMoving | |
| // The polygon is defined counter-clockwise. | ||
| // | ||
| repeated Vector2d base_polygon = 7; | ||
|
|
||
| // Sub-divisions of the overall bounding box of the BaseMoving object. | ||
| // | ||
| // \note The bounding box sections can include side mirrors, cargo, etc. | ||
| // for vehicles, as well as body-part sections for pedestrians. | ||
| // | ||
| repeated BoundingBox bounding_box_section = 9; | ||
| } | ||
|
|
||
| // | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.