From df9caec2a367f4a166b8d9bde2726571549a0db2 Mon Sep 17 00:00:00 2001 From: Thomas Sedlmayer Date: Fri, 4 Nov 2022 10:30:48 +0100 Subject: [PATCH 1/2] Add new traffic sign variability types - Clarify definition of old types to differentiate from new types - Add new types VARIABLE_MOVABLE and VARIABLE_MUTABLE Signed-off-by: Thomas Sedlmayer --- osi_trafficsign.proto | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/osi_trafficsign.proto b/osi_trafficsign.proto index 5eed93647..b417e7b5d 100644 --- a/osi_trafficsign.proto +++ b/osi_trafficsign.proto @@ -9571,12 +9571,23 @@ message TrafficSign // VARIABILITY_OTHER = 1; - // Fixed sign, i.e. always present. + // Sign that can change neither semantically nor positionally, e.g. + // fixed immutable traffic sign. // VARIABILITY_FIXED = 2; - // Temporary or variable sign, e.g. on a sign bridge. + // Sign that can change semantically and positionally. // VARIABILITY_VARIABLE = 3; + + // Sign that can change positionally but not semantically, e.g. + // temporary immutable traffic sign at construction site. + // + VARIABILITY_VARIABLE_MOVABLE = 4; + + // Sign that can change semantically but not positionally, e.g. digital + // traffic sign on traffic sign gantry or analog prism signs. + // + VARIABILITY_VARIABLE_MUTABLE = 5; } } From 4e66c0eede76c94888cf1811b8c1be8a430a33fb Mon Sep 17 00:00:00 2001 From: Thomas Sedlmayer Date: Tue, 15 Nov 2022 14:16:21 +0100 Subject: [PATCH 2/2] Add new variability type and update comments Signed-off-by: Thomas Sedlmayer --- osi_trafficsign.proto | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/osi_trafficsign.proto b/osi_trafficsign.proto index b417e7b5d..4a68c35e2 100644 --- a/osi_trafficsign.proto +++ b/osi_trafficsign.proto @@ -9571,23 +9571,35 @@ message TrafficSign // VARIABILITY_OTHER = 1; - // Sign that can change neither semantically nor positionally, e.g. - // fixed immutable traffic sign. + // Sign that can change neither semantically nor positionally, e.g. a + // fixed, immutable, non-temporary traffic sign. // VARIABILITY_FIXED = 2; - // Sign that can change semantically and positionally. + // Sign that can change semantically and/or positionally, i.e. it is + // left unspecified in which way the sign may change. + // + // \note This value represents a legacy definition. If possible, please + // use the more specific values below to indicate the exact nature of + // variability. // VARIABILITY_VARIABLE = 3; - // Sign that can change positionally but not semantically, e.g. - // temporary immutable traffic sign at construction site. + // Sign that can change positionally but not semantically, e.g. a + // temporary, immutable traffic sign at construction site. + // + VARIABILITY_MOVABLE = 4; + + // Sign that can change semantically but not positionally, e.g. a + // digital traffic sign on traffic sign gantry, or an analog prism + // sign. // - VARIABILITY_VARIABLE_MOVABLE = 4; + VARIABILITY_MUTABLE = 5; - // Sign that can change semantically but not positionally, e.g. digital - // traffic sign on traffic sign gantry or analog prism signs. + // Sign that can change both semantically and positionally, e.g. a + // temporary, digital traffic sign at a construction site, or a digital + // traffic sign attached to a road works vehicle. // - VARIABILITY_VARIABLE_MUTABLE = 5; + VARIABILITY_MOVABLE_AND_MUTABLE = 6; } }