Skip to content

Commit 7abdbe2

Browse files
ThomasNaderBMWpmai
authored andcommitted
Checklist reworked as decided in the Q4/2020-Meeting at ASAM
Signed-off-by: Thomas Nader <thomas.nader@bmw.de>
1 parent f0b626b commit 7abdbe2

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

.github/pull_request_template.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,13 @@ What does it fix?
1010
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
1111
How has it been tested?
1212

13-
#### Mention a member
14-
Add @mentions of the person or team responsible for reviewing proposed changes.
13+
#### Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
14+
- [ ] My suggestion follows the [style and contributors guidelines](https://opensimulationinterface.github.io/osi-documentation/osi/howtocontribute.html).
15+
- [ ] I have taken care about the [documentation](https://opensimulationinterface.github.io/osi-documentation/open-simulation-interface/doc/commenting.html).
16+
- [ ] I have done the [DCO signoff](https://opensimulationinterface.github.io/osi-documentation/open-simulation-interface/doc/howtocontribute.html#developer-certification-of-origin-dco).
17+
- [ ] My changes generate no errors when passing CI tests.
18+
- [ ] I have successfully implemented and tested my fix/feature locally.
19+
- [ ] Appropriate reviewer(s) are assigned.
1520

16-
#### Check the checklist
17-
18-
- [ ] My code and comments follow the [style guidelines](https://opensimulationinterface.github.io/osi-documentation/osi/commenting.html) and [contributors guidelines](https://opensimulationinterface.github.io/osi-documentation/osi/howtocontribute.html) of this project.
19-
- [ ] I have performed a self-review of my own code.
20-
- [ ] I have made corresponding changes to the [documentation](https://github.com/OpenSimulationInterface/osi-documentation).
21-
- [ ] My changes generate no new warnings.
22-
- [ ] I have added tests that prove my fix is effective or that my feature works.
23-
- [ ] New and existing unit tests / travis ci pass locally with my changes.
21+
If you can’t check all of them, please explain why.
22+
If all boxes are checked or commented and you achieved at least one positive review, you can assign the label readyForCCB!

0 commit comments

Comments
 (0)