Skip to content

Commit 6c20ed4

Browse files
committed
Deprecate various car types in favor of new alias TYPE_CAR
This is a result of the harmonization effort across ASAM Open standards Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
1 parent 41cccf3 commit 6c20ed4

File tree

1 file changed

+25
-4
lines changed

1 file changed

+25
-4
lines changed

osi_object.proto

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -764,10 +764,12 @@ message MovingObject
764764
// other OpenX standards (in particular, OpenScenario 1.x and 2.x, and OpenLabel).
765765
// This is primarily for historical reasons. Where a single type from a
766766
// different standard can map to multiple OSI types it is left up to the
767-
// discretion of the OSI implementer how that mapping is achieved. For example,
768-
// a simulator may use the dimensions of a provided 3d model of a vehicle with type
769-
// "car" in OpenScenario, to determine whether it should be a TYPE_SMALL_CAR or
770-
// TYPE_MEDIUM_CAR in OSI.
767+
// discretion of the OSI implementer how that mapping is achieved. In previous
768+
// versions, for example, a simulator might have used the dimensions of a provided
769+
// 3d model of a vehicle with type "car" in OpenScenario, to determine whether it
770+
// should be a TYPE_SMALL_CAR or TYPE_MEDIUM_CAR in OSI. As part of the harmonization
771+
// effort, it should now map to TYPE_CAR, which is an alias of the old TYPE_MEDIUM_CAR,
772+
// and all other car type enums have been deprecated in favor of TYPE_CAR.
771773
//
772774
// \note Vehicle type classification is a complex area and there are no
773775
// universally recognized standards. As such, the boundaries between some of the
@@ -778,6 +780,10 @@ message MovingObject
778780
//
779781
enum Type
780782
{
783+
// Allow aliases in enum
784+
//
785+
option allow_alias = true;
786+
781787
// Type of vehicle is unknown (must not be used in ground truth).
782788
//
783789
TYPE_UNKNOWN = 0;
@@ -790,24 +796,39 @@ message MovingObject
790796
//
791797
// Definition: Hatchback car with maximum length 4 m.
792798
//
799+
// \note Deprecated differentiation, use TYPE_CAR instead
800+
//
793801
TYPE_SMALL_CAR = 2;
794802

795803
// Vehicle is a compact car.
796804
//
797805
// Definition: Hatchback car with length between 4 and 4.5 m.
798806
//
807+
// \note Deprecated differentiation, use TYPE_CAR instead
808+
//
799809
TYPE_COMPACT_CAR = 3;
800810

811+
// Vehicle is a car.
812+
//
813+
// This is to be used for all car-like vehicles, without any
814+
// further differentiated type available.
815+
//
816+
TYPE_CAR = 4;
817+
801818
// Vehicle is a medium car.
802819
//
803820
// Definition: Hatchback or sedan with length between 4.5 and 5 m.
804821
//
822+
// \note Deprecated differentiation, use TYPE_CAR instead, which is an alias
823+
//
805824
TYPE_MEDIUM_CAR = 4;
806825

807826
// Vehicle is a luxury car.
808827
//
809828
// Definition: Sedan or coupe that is longer then 5 m.
810829
//
830+
// \note Deprecated differentiation, use TYPE_CAR instead
831+
//
811832
TYPE_LUXURY_CAR = 5;
812833

813834
// Vehicle is a delivery van.

0 commit comments

Comments
 (0)