Skip to content

Commit 6ab8c1d

Browse files
thomassedlmayerpmai
authored andcommitted
Fix sensordata reference frame definitions
- Remove incorrect parent frame definition for detected moving object - Clarify definition of parent frame for all sensordata objects Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
1 parent 52710bc commit 6ab8c1d

File tree

5 files changed

+60
-6
lines changed

5 files changed

+60
-6
lines changed

osi_detectedlane.proto

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,15 @@ message DetectedLane
5454
//
5555
// \image html OSI_DetectedLaneBoundary.svg
5656
//
57+
// The parent frame of a detected lane boundary is the virtual sensor coordinate
58+
// system.
59+
//
60+
// The virtual sensor coordinate system is relative to the vehicle coordinate
61+
// system which has its origin in the center of the rear axle of the ego
62+
// vehicle. This means if virtual sensor mounting position and orientation are
63+
// set to (0,0,0) the virtual sensor coordinate system coincides with the
64+
// vehicle coordinate system.
65+
//
5766
message DetectedLaneBoundary
5867
{
5968
// Common information of one detected item.

osi_detectedobject.proto

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,15 @@ message DetectedItemHeader
9393
//
9494
// \image html OSI_DetectedStationaryObject.svg
9595
//
96+
// The parent frame of a detected stationary object is the virtual sensor
97+
// coordinate system.
98+
//
99+
// The virtual sensor coordinate system is relative to the vehicle coordinate
100+
// system which has its origin in the center of the rear axle of the ego
101+
// vehicle. This means if virtual sensor mounting position and orientation are
102+
// set to (0,0,0) the virtual sensor coordinate system coincides with the
103+
// vehicle coordinate system.
104+
//
96105
message DetectedStationaryObject
97106
{
98107
// Common information of one detected item.
@@ -172,8 +181,17 @@ message DetectedStationaryObject
172181
}
173182

174183
//
175-
// \brief Moving object in the environment as detected and perceived by
176-
// the sensor.
184+
// \brief Moving object in the environment as detected and perceived by the
185+
// sensor.
186+
//
187+
// The parent frame of a detected moving object is the virtual sensor coordinate
188+
// system.
189+
//
190+
// The virtual sensor coordinate system is relative to the vehicle coordinate
191+
// system which has its origin in the center of the rear axle of the ego
192+
// vehicle. This means if virtual sensor mounting position and orientation are
193+
// set to (0,0,0) the virtual sensor coordinate system coincides with the
194+
// vehicle coordinate system.
177195
//
178196
message DetectedMovingObject
179197
{
@@ -183,8 +201,7 @@ message DetectedMovingObject
183201

184202
// The base parameters of the moving object.
185203
//
186-
// \note The bounding box does NOT includes mirrors for vehicles.
187-
// \note The parent frame of \c base is the sensor's vehicle frame.
204+
// \note The bounding box does NOT include mirrors for vehicles.
188205
// \note The height includes the ground_clearance. It always goes from the
189206
// top to the ground.
190207
//
@@ -194,8 +211,6 @@ message DetectedMovingObject
194211
// moving object (e.g. car). \c MovingObject::base has to be
195212
// identical for all \c #candidate moving objects.
196213
//
197-
// \note The parent frame of \c base is the sensor's vehicle frame.
198-
//
199214
optional BaseMoving base_rmse = 3;
200215

201216
// Reference point location specification of the sensor measurement

osi_detectedroadmarking.proto

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,15 @@ package osi3;
2020
// RoadMarking::Classification::type == \c
2121
// RoadMarking::Classification::TYPE_SYMBOLIC_TRAFFIC_SIGN is not marked.
2222
//
23+
// The parent frame of a detected road marking is the virtual sensor coordinate
24+
// system.
25+
//
26+
// The virtual sensor coordinate system is relative to the vehicle coordinate
27+
// system which has its origin in the center of the rear axle of the ego
28+
// vehicle. This means if virtual sensor mounting position and orientation are
29+
// set to (0,0,0) the virtual sensor coordinate system coincides with the
30+
// vehicle coordinate system.
31+
//
2332
message DetectedRoadMarking
2433
{
2534
// Common information of one detected item.

osi_detectedtrafficlight.proto

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,15 @@ package osi3;
1313
//
1414
// \image html OSI_DetectedTrafficLight.svg
1515
//
16+
// The parent frame of a detected traffic light is the virtual sensor coordinate
17+
// system.
18+
//
19+
// The virtual sensor coordinate system is relative to the vehicle coordinate
20+
// system which has its origin in the center of the rear axle of the ego
21+
// vehicle. This means if virtual sensor mounting position and orientation are
22+
// set to (0,0,0) the virtual sensor coordinate system coincides with the
23+
// vehicle coordinate system.
24+
//
1625
// One detected traffic light message defines a single 'bulb' and not a box of
1726
// several bulbs, e.g. red, yellow, green are three separate detected traffic
1827
// lights.

osi_detectedtrafficsign.proto

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,15 @@ package osi3;
1313
//
1414
// \image html OSI_DetectedSign.svg
1515
//
16+
// The parent frame of a detected traffic sign is the virtual sensor coordinate
17+
// system.
18+
//
19+
// The virtual sensor coordinate system is relative to the vehicle coordinate
20+
// system which has its origin in the center of the rear axle of the ego
21+
// vehicle. This means if virtual sensoqr mounting position and orientation are
22+
// set to (0,0,0) the virtual sensor coordinate system coincides with the
23+
// vehicle coordinate system.
24+
//
1625
message DetectedTrafficSign
1726
{
1827
// Common information of one detected item.
@@ -45,11 +54,14 @@ message DetectedTrafficSign
4554
//
4655
// The orientation of the bounding box \c #base
4756
// ( \c BaseStationary::orientation ) is defined as follows:
57+
//
4858
// The z-axis of the given \c BaseStationary::orientation is the vector
4959
// from the bottom to the top of the traffic sign's 2D image plate.
5060
// (Normally it is equal to the ground truth z-axis.)
61+
//
5162
// The x-axis of the given \c BaseStationary::orientation is view
5263
// normal of the traffic sign's image.
64+
//
5365
// This x-axis points from the traffic sign's image in the direction
5466
// from where a 'viewer' could see the traffic sign image.
5567
//

0 commit comments

Comments
 (0)