Skip to content

Commit 3424a29

Browse files
thomassedlmayerpmai
authored andcommitted
Align mounting position definitions
- Add keyword "physical" for mounting position in SensorDetectionHeader - Remove outdated reference to vehicle reference point - Rephrase reference frame definition for virtual mounting position Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
1 parent e28241f commit 3424a29

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

osi_featuredata.proto

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,9 @@ message SensorDetectionHeader
7070
//
7171
optional uint64 cycle_counter = 2;
7272

73-
// Mounting position of the sensor (origin and orientation of the sensor
74-
// frame). Both origin and orientation are given in and with respect to the
75-
// host vehicle coordinate system (see: \c MovingObject::Vehicle vehicle
76-
// reference point) [1].
73+
// The physical mounting position of the sensor (origin and orientation of
74+
// the sensor frame). Both origin and orientation are given in and with
75+
// respect to the host vehicle coordinate system [1].
7776
//
7877
// The sensor frame's x-axis is pointing in the central viewing direction of
7978
// the sensor. It is the angle bisector of the sensor's horizontal and

osi_sensorview.proto

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,17 @@ message SensorView
6262
//
6363
optional Identifier sensor_id = 3;
6464

65-
// The virtual mounting position of the sensor (origin and orientation
66-
// of the sensor coordinate system) given in vehicle coordinates [1].
67-
// The virtual position pertains to the sensor as a whole, regardless
68-
// of the actual position of individual physical detectors, and governs
69-
// the sensor-relative coordinates in detected objects of the sensor
70-
// as a whole. Individual features detected by individual physical
71-
// detectors are governed by the actual physical mounting positions
72-
// of the detectors, as indicated in the technology-specific sub-views
73-
// and sub-view configurations.
65+
// The virtual mounting position of the sensor (origin and orientation of
66+
// the sensor frame). Both origin and orientation are given in and with
67+
// respect to the host vehicle coordinate system [1].
68+
//
69+
// The virtual position pertains to the sensor as a whole, regardless of the
70+
// actual position of individual physical detectors, and governs the
71+
// sensor-relative coordinates in detected objects of the sensor as a whole.
72+
// Individual features detected by individual physical detectors are
73+
// governed by the actual physical mounting positions of the detectors, as
74+
// indicated in the technology-specific sub-views and sub-view
75+
// configurations.
7476
//
7577
// \arg \b x-direction of sensor coordinate system: sensor viewing direction
7678
// \arg \b z-direction of sensor coordinate system: sensor (up)

0 commit comments

Comments
 (0)