Skip to content

Commit 267c327

Browse files
pmaiKmeid
andcommitted
Apply suggestions from code review for environment additions
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Co-authored-by: Kmeid <kmeid.saad@ansys.com>
1 parent 777e4d1 commit 267c327

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

osi_environment.proto

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,9 +338,7 @@ message EnvironmentalConditions
338338
}
339339

340340
//
341-
// \brief Specification of the cloud layer.
342-
//
343-
// \note within this message there is the cloud state level.
341+
// \brief Specification of a cloud layer.
344342
//
345343
message CloudLayer
346344
{
@@ -350,7 +348,7 @@ message EnvironmentalConditions
350348

351349
// Defines the cloud state levels given by observation of total cloud amount in oktas.
352350
//
353-
// For visual alignment please call the reference[1]
351+
// For visual alignment please see reference[1].
354352
//
355353
// The total degree of coverage indicates how large the part of the sky vault is which is covered
356354
// with clouds altogether. It is given in eighths, because this division is easier to estimate
@@ -439,16 +437,16 @@ message EnvironmentalConditions
439437
//
440438
// Unit: rad
441439
//
442-
// The preferred angular range is [-pi, pi]
440+
// The preferred angular range is [-pi, pi].
443441
//
444442
// \note The direction is the origin, not the target direction. \c
445443
// The range in openSCENARIO is Range [0...2 pi[. Mind the conversion.
446444
//
447-
optional Vector3d origin_direction = 1;
445+
optional double origin_direction = 1;
448446

449447
// The wind speed.
450448
//
451-
// Unit m/s
449+
// Unit: m/s
452450
//
453451
// Range [0...inf[
454452
//
@@ -466,19 +464,19 @@ message EnvironmentalConditions
466464
//
467465
// Unit: rad
468466
//
469-
// The preferred angular range is [-pi, pi]
467+
// The preferred angular range is [-pi, pi].
470468
//
471469
optional double azimuth = 1;
472470

473471
// Solar elevation angle.
474472
//
475473
// Unit: rad
476474
//
477-
// The preferred angular range is [-pi, pi]
475+
// The preferred angular range is [-pi, pi].
478476
//
479477
optional double elevation = 2;
480478

481-
// Illuminance of the sun, direct sunlight is around 100,00 lx.
479+
// Illuminance of the sun, direct sunlight is around 100000 lx.
482480
//
483481
// Unit: lx
484482
//

0 commit comments

Comments
 (0)