Skip to content

Commit 1ab8432

Browse files
thempenpmai
authored andcommitted
Updated the BoundingBox message.
- Clarified the position definition. - Added a "other_object_type" sting to define object types, which are not part of the Type definition enum. - Reduced the Type field, because of compatibility reason. There is a general approach to harmonize object type definitions. So the definition should not get in conflict to that approach. Signed-off-by: Thomas Hempen <thomas.hempen@carissma.eu>
1 parent c71f9c3 commit 1ab8432

File tree

1 file changed

+13
-60
lines changed

1 file changed

+13
-60
lines changed

osi_common.proto

Lines changed: 13 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,8 @@ message BoundingBox
408408
//
409409
optional Dimension3d dimension = 1;
410410

411-
// The 3D position of the bounding box.
411+
// The 3D position of the bounding box. The position is the center
412+
// of the bounding box and the pivot for the \c dimension and \c orientation.
412413
//
413414
// \note The position should be within the same coordinate frame as
414415
// its parent, not relative to coordinate frame of the parent object.
@@ -430,16 +431,26 @@ message BoundingBox
430431
//
431432
optional Type contained_object_type = 4;
432433

434+
// Another type of object contained in the bounding box
435+
//
436+
// This field shall only be used if \c contained_object_type is TYPE_OTHER
437+
// and the object type is not defined withing \c contained_object_type.
438+
//
439+
optional string other_object_type = 5;
440+
433441
// Opaque reference of an associated 3D model of the bounding box.
434442
//
435443
// \note It is implementation-specific how model_references are resolved to
436444
// 3d models. This means the coordinate system, model origin, and model
437445
// orientation are also implementation-specific.
438446
//
439-
optional string model_reference = 5;
447+
optional string model_reference = 6;
440448

441449
// Definition of different types of object contained within the bounding box
442450
//
451+
// \note This enum field is mainly a placeholder to be extended in the future.
452+
// feel free to suggest type definitions for future releases.
453+
//
443454
enum Type
444455
{
445456
// Object of unknown type (must not be used in ground truth).
@@ -449,64 +460,6 @@ message BoundingBox
449460
// Any other type of object.
450461
//
451462
TYPE_OTHER = 1;
452-
453-
// The main chassis of a vehicle.
454-
//
455-
TYPE_CHASSIS = 2;
456-
457-
// The door of a vehicle.
458-
//
459-
TYPE_DOOR = 3;
460-
461-
// The side mirror of a vehicle.
462-
//
463-
// \note The side mirror is not included in the overall bounding box
464-
// of the parent object.
465-
//
466-
TYPE_SIDE_MIRROR = 4;
467-
468-
// Additional cargo attached to the a vehicle which is temporarily
469-
// attached.
470-
//
471-
TYPE_CARGO = 5;
472-
473-
// The wheel of a vehicle.
474-
//
475-
// \note For more detailed information about the wheels of an object,
476-
// please refer to \c MovingObject/VehicleAttributes/WheelData.
477-
//
478-
TYPE_WHEEL = 6;
479-
480-
// The torso section of a person or animal.
481-
//
482-
TYPE_TORSO = 7;
483-
484-
// An external limb of a person or animal.
485-
//
486-
// \note Limbs can be sub-divided to increase accuracy, i.e. for upper
487-
// and lower arm/leg sections.
488-
//
489-
TYPE_LIMB = 8;
490-
491-
// The head of a person or animal.
492-
//
493-
TYPE_HEAD = 9;
494-
495-
// The trunk section of a tree.
496-
//
497-
TYPE_TREE_TRUNK = 10;
498-
499-
// The crown of a tree, usually encompassing the branches and leaves.
500-
//
501-
TYPE_TREE_CROWN = 11;
502-
503-
// The vertical pole of a street light.
504-
//
505-
TYPE_STREET_LIGHT_POLE = 12;
506-
507-
// The horizontal arm of a street light.
508-
//
509-
TYPE_STREET_LIGHT_ARM = 13;
510463
}
511464
}
512465

0 commit comments

Comments
 (0)