Skip to content

Commit 120d15a

Browse files
authored
Merge pull request #46 from OpenSimulationInterface/improve-mounting-position-comment
improved comment of SensorData::mounting_position
2 parents 33638f9 + 40be3df commit 120d15a

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

osi_common.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ message InterfaceVersion
1313
/// happen as part of changes to the whole interface.
1414
optional uint32 major = 1 [default = 2];
1515
optional uint32 minor = 2 [default = 0];
16-
optional uint32 patch = 3 [default = 0];
16+
optional uint32 patch = 3 [default = 1];
1717
}
1818

1919
///

osi_sensordata.proto

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,13 @@ message SensorData
3737
// The id of the ego vehicle in the ground_truth data.
3838
optional Identifier ego_vehicle_id = 4;
3939

40-
// The mounting position of the sensor (origin and orientation of the sensor coordinate system); given relative
41-
// to the middle of the rear axis of the host vehicle.
40+
// The mounting position of the sensor (origin and orientation of the sensor coordinate system);
41+
// given in vehicle coordinates: origin is Vehicle::reference_point; the orientation is equal to the orientation of the vehicle.
42+
// x-direction: longitudinal direction & positive in driving direction;
43+
// y-direction: lateral direction & positive to the left when looking orientated as a driver;
44+
// z-direction: perpendicular to x and z right hand system (up).
45+
// See https://en.wikipedia.org/wiki/Axes_conventions#/media/File:RPY_angles_of_cars.png
46+
// Note that this field is usually static during the simulation.
4247
optional MountingPosition mounting_position = 5;
4348

4449
// The list of objects detected by the sensor as perceived by the sensor.

0 commit comments

Comments
 (0)