Add drone login credential management #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 839a2b2)
vertexodessa
reviewed
Dec 3, 2025
| private ConstraintSet constraintSet; | ||
| private WfbNgLink wfbLink; | ||
|
|
||
| private static final String PREF_DRONE_USERNAME = "drone_username"; |
Collaborator
There was a problem hiding this comment.
I'd prefer to have it working by default - i.e. having the root/12345 if nothing else was chosen
Collaborator
There was a problem hiding this comment.
since root/12345 is publicly disclosed as the default OpenIPC password, I believe it doesn't make sense to hide it
Contributor
Author
There was a problem hiding this comment.
A few days ago I opened Drone Settings, and the WebUI page required me to set a new password, so I set 123456 (not knowing 12345 is the default). I could never open Drone Settings ever since... the root/12345 will still be default, the credentials option is added just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded username & password.