simplify

Author: malhotra5

tests/cross/test_agent_reconciliation.py

@@ -271,7 +271,6 @@ def test_conversation_persistence_lifecycle(mock_completion):
         # Verify state was restored
         assert new_conversation.id == original_id
         # When loading from persistence, the state should be exactly the same
-        # (no additional SecurityAnalyzerConfigurationEvent should be added)
         assert len(new_conversation.state.events) == original_event_count
         # Test model_dump equality (excluding events which may have different timestamps)  # noqa: E501
         new_dump = new_conversation._state.model_dump(mode="json", exclude={"events"})

tests/sdk/tool/test_to_responses_tool_security.py

@@ -41,7 +41,7 @@ def create(cls, conv_state=None, **params) -> Sequence["MockSecurityTool3"]:
 
 
 def test_to_responses_tool_security_gating():
-    # security_risk field is now always included regardless of readOnlyHint
+    # readOnlyHint=True -> do not add security_risk even if requested
     readonly = MockSecurityTool1(
         description="d",
         action_type=TRTSAction,
@@ -53,9 +53,9 @@ def test_to_responses_tool_security_gating():
     assert isinstance(params, dict)
     props = params.get("properties") or {}
     assert isinstance(props, dict)
-    assert "security_risk" in props  # Always included now
+    assert "security_risk" not in props
 
-    # readOnlyHint=False -> also includes security_risk
+    # readOnlyHint=False -> add when requested
     writable = MockSecurityTool2(
         description="d",
         action_type=TRTSAction,

tests/sdk/tool/test_tool_definition.py

@@ -542,8 +542,8 @@ class ComplexNestedAction(Action):
         assert optional_array_schema["type"] == "array"
         assert optional_array_schema["items"]["type"] == "string"
 
-    def test_security_risk_added_for_all_tools_when_enabled(self):
-        """Test that security_risk is added for all tools when prediction is enabled."""
+    def test_security_risk_only_added_for_non_readonly_tools(self):
+        """Test that security_risk is only added if the tool is not read-only."""
         # Test with read-only tool
         readonly_annotations = ToolAnnotations(
             title="Read-only Tool",
@@ -578,16 +578,14 @@ def test_security_risk_added_for_all_tools_when_enabled(self):
             annotations=None,
         )
 
-        # Test read-only tool - security_risk should be added when enabled
+        # Test read-only tool - security_risk should NOT be added
         readonly_openai_tool = readonly_tool.to_openai_tool(
             add_security_risk_prediction=True
         )
         readonly_function = readonly_openai_tool["function"]
         assert "parameters" in readonly_function
         readonly_params = readonly_function["parameters"]
-        assert (
-            "security_risk" in readonly_params["properties"]
-        )  # Included for read-only tools too
+        assert "security_risk" not in readonly_params["properties"]
 
         # Test writable tool - security_risk SHOULD be added
         writable_openai_tool = writable_tool.to_openai_tool(