👔 refactor: add openfunction signature type

Signed-off-by: Haili Zhang <haili.zhang@outlook.com>

Author: webup

src/function_wrappers.ts

@@ -131,7 +131,7 @@ const wrapHttpFunction = (execute: HttpFunction): RequestHandler => {
   };
 };
 
-const wrapHttpAsyncFunction = (
+const wrapOpenFunction = (
   userFunction: OpenFunction,
   context: OpenFunctionContext
 ): RequestHandler => {
@@ -247,12 +247,12 @@ export const wrapUserFunction = <T = unknown>(
 ): RequestHandler => {
   switch (signatureType) {
     case 'http':
-      if (!isEmpty((context as OpenFunctionContext)?.outputs))
-        return wrapHttpAsyncFunction(
-          userFunction as OpenFunction,
-          context as OpenFunctionContext
-        );
       return wrapHttpFunction(userFunction as HttpFunction);
+    case 'openfunction':
+      return wrapOpenFunction(
+        userFunction as OpenFunction,
+        context as OpenFunctionContext
+      );
     case 'event':
       // Callback style if user function has more than 2 arguments.
       if (userFunction!.length > 2) {

src/types.ts

@@ -19,7 +19,12 @@ export const FUNCTION_STATUS_HEADER_FIELD = 'X-Google-Status';
 /**
  * List of function signature types that are supported by the framework.
  */
-export const SignatureType = ['http', 'event', 'cloudevent'] as const;
+export const SignatureType = [
+  'http',
+  'event',
+  'cloudevent',
+  'openfunction',
+] as const;
 
 /**
  * Union type of all valid function SignatureType values.

test/conformance/package.json

@@ -7,9 +7,9 @@
     "wait-on": "file:../../node_modules/wait-on"
   },
   "scripts": {
-    "start": "functions-framework",
+    "start": "functions-framework --target=writeHttp",
     "knative:async": "concurrently npm:knative:async:run:* npm:knative:async:test",
-    "knative:async:run:func": "cross-env DEBUG=test:*,common:*,ofn:* env-cmd -e knative functions-framework --target=tryKnativeAsync",
+    "knative:async:run:func": "cross-env DEBUG=test:*,common:*,ofn:* env-cmd -e knative functions-framework --signature-type=openfunction --target=tryKnativeAsync",
     "knative:async:run:dapr": "dapr run -H 3500 -d ../data/components/http --log-level warn",
     "knative:async:test": "wait-on tcp:3500 tcp:8080 && curl -s -d '{\"data\": \"hello\"}' -H 'Content-Type: application/json' localhost:8080",
     "async": "concurrently npm:async:run:*",

test/integration/http_binding.ts

@@ -86,7 +86,7 @@ describe('OpenFunction - HTTP Binding', () => {
           await ctx.send(data);
           return ctx.response(data);
         },
-        'http',
+        'openfunction',
         context
       );