Skip to content

Commit 72852d0

Browse files
fix: update conformance tests (GoogleCloudPlatform#108)
Update the conformance tests action to 1.0.0 and fix firebasedb event conversion bug.
1 parent 9a576de commit 72852d0

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

.github/workflows/conformance.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ jobs:
3434
run: (cd invoker/ && mvn install)
3535

3636
- name: Run HTTP conformance tests
37-
uses: GoogleCloudPlatform/functions-framework-conformance/action@v0.3.12
37+
uses: GoogleCloudPlatform/functions-framework-conformance/action@v1.0.0
3838
with:
3939
functionType: 'http'
4040
useBuildpacks: false
4141
cmd: "'mvn -f invoker/conformance/pom.xml function:run -Drun.functionTarget=com.google.cloud.functions.conformance.HttpConformanceFunction'"
4242
startDelay: 10
4343

4444
- name: Run background event conformance tests
45-
uses: GoogleCloudPlatform/functions-framework-conformance/action@v0.3.12
45+
uses: GoogleCloudPlatform/functions-framework-conformance/action@v1.0.0
4646
with:
4747
functionType: 'legacyevent'
4848
useBuildpacks: false
@@ -51,7 +51,7 @@ jobs:
5151
startDelay: 10
5252

5353
- name: Run cloudevent conformance tests
54-
uses: GoogleCloudPlatform/functions-framework-conformance/action@v0.3.12
54+
uses: GoogleCloudPlatform/functions-framework-conformance/action@v1.0.0
5555
with:
5656
functionType: 'cloudevent'
5757
useBuildpacks: false

invoker/core/src/main/java/com/google/cloud/functions/invoker/GcfEvents.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,13 @@ class GcfEvents {
8282
new FirestoreFirebaseEventAdapter("google.firebase.analytics.log.v1.written", FIREBASE_SERVICE)),
8383

8484
entry("providers/google.firebase.database/eventTypes/ref.create",
85-
new FirebaseDatabaseEventAdapter("google.firebase.database.document.v1.created")),
85+
new FirebaseDatabaseEventAdapter("google.firebase.database.ref.v1.created")),
8686
entry("providers/google.firebase.database/eventTypes/ref.write",
87-
new FirebaseDatabaseEventAdapter("google.firebase.database.document.v1.written")),
87+
new FirebaseDatabaseEventAdapter("google.firebase.database.ref.v1.written")),
8888
entry("providers/google.firebase.database/eventTypes/ref.update",
89-
new FirebaseDatabaseEventAdapter("google.firebase.database.document.v1.updated")),
89+
new FirebaseDatabaseEventAdapter("google.firebase.database.ref.v1.updated")),
9090
entry("providers/google.firebase.database/eventTypes/ref.delete",
91-
new FirebaseDatabaseEventAdapter("google.firebase.database.document.v1.deleted")),
91+
new FirebaseDatabaseEventAdapter("google.firebase.database.ref.v1.deleted")),
9292

9393
entry("providers/cloud.pubsub/eventTypes/topic.publish",
9494
new PubSubEventAdapter(PUB_SUB_MESSAGE_PUBLISHED)),

invoker/core/src/test/java/com/google/cloud/functions/invoker/GcfEventsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ public class GcfEventsTest {
5151
"//pubsub.googleapis.com/projects/sample-project/topics/gcf-test", null},
5252
{"legacy_pubsub.json", "google.cloud.pubsub.topic.v1.messagePublished",
5353
"//pubsub.googleapis.com/projects/sample-project/topics/gcf-test", null},
54-
{"firebase-db1.json", "google.firebase.database.document.v1.written",
54+
{"firebase-db1.json", "google.firebase.database.ref.v1.written",
5555
"//firebasedatabase.googleapis.com/projects/_/locations/us-central1/instances/my-project-id",
5656
"refs/gcf-test/xyz"},
57-
{"firebase-db2.json", "google.firebase.database.document.v1.written",
57+
{"firebase-db2.json", "google.firebase.database.ref.v1.written",
5858
"//firebasedatabase.googleapis.com/projects/_/locations/europe-west1/instances/my-project-id",
5959
"refs/gcf-test/xyz"},
6060
{"firebase-auth1.json", "google.firebase.auth.user.v1.created",

0 commit comments

Comments
 (0)