ci: Update release workflow #1600
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are unused, leftover dead code.
nan-li
force-pushed
the
chore/cd_create_release_pr
branch
5 times, most recently
from
fdb343a to
e1d53ad
Compare
nan-li
force-pushed
the
chore/cd_create_release_pr
branch
6 times, most recently
from
3721793 to
1f7a8b5
Compare
* This script will read the VERSION and update the 2 podspec files and the ONESIGNAL_VERSION's in the SDK * Add this to the CD script as a step. * This is similar to existing scripts `update_swift_package.sh` and `build_all_frameworks.sh` - Also, rename cd.yml to create-release-prs.yml for clarity
Creates GH release for OneSignal-iOS-SDK. Does not create release for OneSignal-XCFramework
* Pushes OneSignal and OneSignalXCFramework pods * Takes the release notes from OneSignal-iOS-SDK and makes a release XCFramework
* For release automation workflow, we copy Package.swift to the XCFramework repository and rename the package name from "OneSignalFramework" to "OneSignalXCFramework". Since there are multiple occurrances of `name: "OneSignalFramework"` in this file, we ONLY want to change line 7!
nan-li
force-pushed
the
chore/cd_create_release_pr
branch
from
1f7a8b5 to
6d39e2f
Compare
| jobs: | ||
| # Step 1: Extract version from podspec | ||
| get-version: | ||
| runs-on: ubuntu-latest |
| # Step 3: Upload the 10 xcframework zips to the release | ||
| upload-assets: | ||
| needs: [get-version, create-release] | ||
| runs-on: macos-13 |
There was a problem hiding this comment.
oh you are using two instances? why dont do everything in one isntance?
Contributor
There was a problem hiding this comment.
Id imagine for this upload job, ubuntu should work?
| runs-on: macos-13 | ||
|
|
||
| env: | ||
| VERSION: ${{ needs.get-version.outputs.version }} |
| # Push to remote | ||
| git push origin $RELEASE_BRANCH | ||
| env: | ||
| GH_TOKEN: ${{ secrets.PAT_TOKEN_ONESIGNAL_XCFRAMEWORK }} |
There was a problem hiding this comment.
why dont you do it once for the entire job?
Contributor
Author
There was a problem hiding this comment.
We have to push to another repository https://github.com/OneSignal/OneSignal-XCFramework, and I need a different PAT token.
| # Step 3: Use reusable workflow to create iOS SDK PR with release notes | ||
| create-ios-pr: | ||
| needs: [prep, update-and-build] | ||
| uses: OneSignal/sdk-actions/.github/workflows/create-release.yml@main |
| echo "This release corresponds to [OneSignal-iOS-SDK $VERSION](https://github.com/OneSignal/OneSignal-iOS-SDK/releases/tag/$VERSION)" >> release_notes.md | ||
| fi | ||
|
|
||
| # Determine if this is a pre-release |
There was a problem hiding this comment.
all this should be handled by the action right?
Contributor
Author
There was a problem hiding this comment.
By the action? We can't use the shared workflows to push to another repo.
fadi-george
reviewed
Nov 10, 2025
| # This workflow creates a GitHub release in iOS-SDK and attaches the built zip files. | ||
| # Run this AFTER the release PR has been merged. | ||
|
|
||
| on: |
Contributor
There was a problem hiding this comment.
could run on merge of the release pr instead? e.g.
https://github.com/OneSignal/react-native-onesignal/blob/main/.github/workflows/cd.yml
fadi-george
reviewed
Nov 10, 2025
| @@ -0,0 +1,236 @@ | |||
| name: Create Release PRs | |||
Contributor
There was a problem hiding this comment.
nit: file and name should be singular
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update release workflow for version bumps, building, creating GitHub releases, pushing to XCFramework repository, and pushing to Cocoapods.
Details - Workflow steps:
1. Create Release PR (
create-release-prs.yml)⏸️ Action Needed: Approve and merge PRs
2. Create GitHub Release in OneSignal-iOS-SDK (
create_github_release.yml)⏸️ Action Needed (optional): Here is chance to test releases before pushing out to package managers
3. Release SDK (
publish-release.yml)See #1613 and OneSignal/OneSignal-XCFramework#133 for example release PRs.
Motivation
Automate release workflow
Scope
Release workflow
Testing
Manual testing
Testing through manual triggers
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is