Skip to content

Commit 7a22b21

Browse files
committed
nit(cleanup): remove unused semantic version helpers
These methods are unused, leftover dead code.
1 parent 47972a4 commit 7a22b21

File tree

4 files changed

+0
-45
lines changed

4 files changed

+0
-45
lines changed

iOS_SDK/OneSignalSDK/OneSignalCore/Source/Categories/NSString+OneSignal.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@
3131
#define NSString_OneSignal_h
3232
@interface NSString (OneSignal)
3333

34-
- (NSString *_Nonnull)one_getVersionForRange:(NSRange)range;
3534
- (NSString *_Nonnull)one_substringAfter:(NSString *_Nonnull)needle;
36-
- (NSString *_Nonnull)one_getSemanticVersion;
3735
- (NSString *_Nullable)fileExtensionForMimeType;
3836
- (NSString *_Nullable)supportedFileExtension;
3937

iOS_SDK/OneSignalSDK/OneSignalCore/Source/Categories/NSString+OneSignal.m

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -41,30 +41,6 @@ - (NSString *)one_substringAfter:(NSString *)needle
4141
}
4242

4343

44-
- (NSString*)one_getVersionForRange:(NSRange)range {
45-
46-
unichar myBuffer[2];
47-
[self getCharacters:myBuffer range:range];
48-
NSString *ver = [NSString stringWithCharacters:myBuffer length:2];
49-
if([ver hasPrefix:@"0"]){
50-
return [ver one_substringAfter:@"0"];
51-
}
52-
else{
53-
return ver;
54-
}
55-
}
56-
57-
- (NSString*)one_getSemanticVersion {
58-
59-
NSMutableString *tmpstr = [[NSMutableString alloc] initWithCapacity:5];
60-
61-
for ( int i = 0; i <=4; i+=2 ){
62-
[tmpstr appendString:[self one_getVersionForRange:NSMakeRange(i, 2)]];
63-
if (i != 4)[tmpstr appendString:@"."];
64-
}
65-
66-
return (NSString*)tmpstr;
67-
}
6844

6945
- (NSString *)supportedFileExtension {
7046
NSArray <NSString *> *components = [self componentsSeparatedByString:@"."];

iOS_SDK/OneSignalSDK/Source/OneSignal.m

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -133,22 +133,6 @@ + (OneSignalReceiveReceiptsController*)receiveReceiptsController {
133133
return _receiveReceiptsController;
134134
}
135135

136-
+ (NSString*)sdkVersionRaw {
137-
return ONESIGNAL_VERSION;
138-
}
139-
140-
// TODO: Is this method used by wrappers? It is not used by this SDK. Can we remove?
141-
+ (NSString*)sdkSemanticVersion {
142-
// examples:
143-
// ONESIGNAL_VERSION = @"020402" returns 2.4.2
144-
// ONESIGNAL_VERSION = @"001000" returns 0.10.0
145-
// so that's 6 digits, where the first two are the major version
146-
// the second two are the minor version and that last two, the patch.
147-
// c.f. http://semver.org/
148-
149-
return [ONESIGNAL_VERSION one_getSemanticVersion];
150-
}
151-
152136
//TODO: This is related to unit tests and will change with um tests
153137
+ (void)clearStatics {
154138
[OneSignalConfigManager setAppId:nil];

iOS_SDK/OneSignalSDK/Source/OneSignalFramework.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@ typedef void (^OSFailureBlock)(NSError* error);
6262
// ======= OneSignal Class Interface =========
6363
@interface OneSignal : NSObject
6464

65-
+ (NSString* _Nonnull)sdkVersionRaw;
66-
+ (NSString* _Nonnull)sdkSemanticVersion;
67-
6865
#pragma mark User
6966
+ (id<OSUser>)User NS_REFINED_FOR_SWIFT;
7067
+ (void)login:(NSString * _Nonnull)externalId;

0 commit comments

Comments
 (0)