add unknown op error

Author: fadi-george

src/core/executors/CustomEventOperationExecutor.ts

@@ -3,6 +3,7 @@ import {
   getDeviceOS,
   getSubscriptionType,
 } from 'src/shared/environment/detect';
+import { UnknownOpError } from 'src/shared/errors/common';
 import {
   getResponseStatusType,
   ResponseStatusType,
@@ -44,9 +45,7 @@ export class CustomEventsOperationExecutor implements IOperationExecutor {
     const operation = operations[0];
 
     if (!(operation instanceof TrackCustomEventOperation)) {
-      throw new Error(
-        `Unrecognized operation! Expected TrackEventOperation, got: ${operation.constructor.name}`,
-      );
+      throw UnknownOpError(operation);
     }
 
     const response = await sendCustomEvent(

src/core/executors/IdentityOperationExecutor.ts

@@ -4,6 +4,7 @@ import {
   type IOperationExecutor,
 } from 'src/core/types/operation';
 import type { IRebuildUserService } from 'src/core/types/user';
+import { UnknownOpError } from 'src/shared/errors/common';
 import {
   getResponseStatusType,
   ResponseStatusType,
@@ -40,9 +41,7 @@ export class IdentityOperationExecutor implements IOperationExecutor {
   }
 
   async _execute(operations: Operation[]): Promise<ExecutionResponse> {
-    debug(
-      `IdentityOperationExecutor(operations: ${JSON.stringify(operations)})`,
-    );
+    debug(`IdentityOperationExecutor`);
 
     const invalidOps = operations.filter(
       (op) =>
@@ -51,11 +50,7 @@ export class IdentityOperationExecutor implements IOperationExecutor {
         ),
     );
     if (invalidOps.length > 0) {
-      throw new Error(
-        `Unrecognized operation(s)! Attempted operations:\n${JSON.stringify(
-          operations,
-        )}`,
-      );
+      throw UnknownOpError(operations);
     }
 
     const hasSetAlias = operations.some(

src/core/executors/LoginUserOperationExecutor.ts

@@ -3,6 +3,7 @@ import {
   ExecutionResult,
   type IOperationExecutor,
 } from 'src/core/types/operation';
+import { UnknownOpError } from 'src/shared/errors/common';
 import { getTimeZoneId } from 'src/shared/helpers/general';
 import {
   getResponseStatusType,
@@ -62,15 +63,13 @@ export class LoginUserOperationExecutor implements IOperationExecutor {
   }
 
   async _execute(operations: Operation[]): Promise<ExecutionResponse> {
-    debug(
-      `LoginUserOperationExecutor(operation: ${JSON.stringify(operations)})`,
-    );
+    debug(`LoginUserOperationExecutor`);
     const startingOp = operations[0];
 
     if (startingOp instanceof LoginUserOperation)
       return this._loginUser(startingOp, operations.slice(1));
 
-    throw new Error(`Unrecognized operation: ${startingOp._name}`);
+    throw UnknownOpError(startingOp);
   }
 
   private async _loginUser(
@@ -163,7 +162,7 @@ export class LoginUserOperationExecutor implements IOperationExecutor {
           subscriptions,
         );
       } else {
-        throw new Error(`Unrecognized operation: ${operation._name}`);
+        throw UnknownOpError(operation);
       }
     }
 

src/core/executors/RefreshUserOperationExecutor.ts

@@ -1,3 +1,4 @@
+import { UnknownOpError } from 'src/shared/errors/common';
 import {
   getResponseStatusType,
   ResponseStatusType,
@@ -52,16 +53,10 @@ export class RefreshUserOperationExecutor implements IOperationExecutor {
   }
 
   async _execute(operations: Operation[]): Promise<ExecutionResponse> {
-    debug(
-      `RefreshUserOperationExecutor(operation: ${JSON.stringify(operations)})`,
-    );
+    debug(`RefreshUserOperationExecutor`);
 
     if (operations.some((op) => !(op instanceof RefreshUserOperation)))
-      throw new Error(
-        `Unrecognized operation(s)! Attempted operations:\n${JSON.stringify(
-          operations,
-        )}`,
-      );
+      throw UnknownOpError(operations);
 
     const startingOp = operations[0];
     return this._getUser(startingOp);

src/core/executors/SubscriptionOperationExecutor.ts

@@ -3,6 +3,7 @@ import {
   type IOperationExecutor,
 } from 'src/core/types/operation';
 import type { IRebuildUserService } from 'src/core/types/user';
+import { UnknownOpError } from 'src/shared/errors/common';
 import {
   getResponseStatusType,
   ResponseStatusType,
@@ -79,7 +80,7 @@ export class SubscriptionOperationExecutor implements IOperationExecutor {
         );
       return this._transferSubscription(startingOp);
     }
-    throw new Error(`Unrecognized operation: ${startingOp}`);
+    throw UnknownOpError(startingOp);
   }
 
   private async _createSubscription(

src/core/executors/UpdateUserOperationExecutor.ts

@@ -1,3 +1,4 @@
+import { UnknownOpError } from 'src/shared/errors/common';
 import {
   getResponseStatusType,
   ResponseStatusType,
@@ -65,7 +66,7 @@ export class UpdateUserOperationExecutor implements IOperationExecutor {
           propertiesObject,
         );
       } else {
-        throw new Error(`Unrecognized operation: ${operation}`);
+        throw UnknownOpError(operation);
       }
     }
 

src/core/modelRepo/OperationModelStore.ts

@@ -1,4 +1,5 @@
 import type { IDBStoreName } from 'src/shared/database/types';
+import { UnknownOpError } from 'src/shared/errors/common';
 import { error } from 'src/shared/libraries/log';
 import { OPERATION_NAME } from '../constants';
 import { CreateSubscriptionOperation } from '../operations/CreateSubscriptionOperation';
@@ -71,7 +72,7 @@ export class OperationModelStore extends ModelStore<Operation> {
         operation = new TrackCustomEventOperation();
         break;
       default:
-        throw new Error(`Unrecognized operation: ${operationName}`);
+        throw UnknownOpError({ _name: operationName });
     }
 
     // populate the operation with the data

src/shared/errors/common.ts

@@ -65,3 +65,6 @@ export const WrongTypeArgumentError = (argName: string) =>
 
 export const ReservedArgumentError = (argName: string) =>
   new Error(`"${argName}" is reserved`);
+
+export const UnknownOpError = (op: { _name?: string } | { _name?: string }[]) =>
+  new Error(`Unknown op(s):${op}`);