Nit: rename method for clarity

Motivation: it's unclear from the previous method name that we are expecting something to be returned.

Author: Rodrigo Gomez Palacio

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/consistency/impl/ConsistencyManager.kt

@@ -44,7 +44,7 @@ class ConsistencyManager : IConsistencyManager {
     /**
      * Register a condition with its corresponding deferred action. Returns a deferred condition.
      */
-    override suspend fun registerCondition(condition: ICondition): CompletableDeferred<String?> {
+    override suspend fun getRywDataFromAwaitableCondition(condition: ICondition): CompletableDeferred<RywData?> {
         mutex.withLock {
             val deferred = CompletableDeferred<String?>()
             val pair = Pair(condition, deferred)

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/consistency/models/IConsistencyManager.kt

@@ -22,7 +22,7 @@ interface IConsistencyManager {
      *  condition: ICondition - the condition to be registered
      * Returns: CompletableDeferred<String?> - a deferred action that completes when the condition is met
      */
-    suspend fun registerCondition(condition: ICondition): CompletableDeferred<String?>
+    suspend fun getRywDataFromAwaitableCondition(condition: ICondition): CompletableDeferred<String?>
 
     /**
      * Resolve all conditions with a specific ID

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/common/consistency/ConsistencyManagerTests.kt

@@ -25,7 +25,7 @@ class ConsistencyManagerTests : FunSpec({
             consistencyManager.setRywToken(id, key, value)
 
             val condition = TestMetCondition(mapOf(id to mapOf(key to value)))
-            val deferred = consistencyManager.registerCondition(condition)
+            val deferred = consistencyManager.getRywDataFromAwaitableCondition(condition)
             val result = deferred.await()
 
             result shouldBe value
@@ -43,7 +43,7 @@ class ConsistencyManagerTests : FunSpec({
             consistencyManager.setRywToken(id, key, value)
 
             val condition = TestMetCondition(mapOf(id to mapOf(key to value)))
-            val deferred = consistencyManager.registerCondition(condition)
+            val deferred = consistencyManager.getRywDataFromAwaitableCondition(condition)
 
             deferred.await()
             deferred.isCompleted shouldBe true
@@ -53,7 +53,7 @@ class ConsistencyManagerTests : FunSpec({
     test("registerCondition does not complete when condition is not met") {
         runTest {
             val condition = TestUnmetCondition()
-            val deferred = consistencyManager.registerCondition(condition)
+            val deferred = consistencyManager.getRywDataFromAwaitableCondition(condition)
 
             consistencyManager.setRywToken("id", IamFetchRywTokenKey.USER, "123")
             deferred.isCompleted shouldBe false
@@ -63,7 +63,7 @@ class ConsistencyManagerTests : FunSpec({
     test("resolveConditionsWithID resolves conditions based on ID") {
         runTest {
             val condition = TestUnmetCondition()
-            val deferred = consistencyManager.registerCondition(condition)
+            val deferred = consistencyManager.getRywDataFromAwaitableCondition(condition)
             consistencyManager.resolveConditionsWithID(TestUnmetCondition.ID)
             deferred.await()
 

OneSignalSDK/onesignal/in-app-messages/src/main/java/com/onesignal/inAppMessages/internal/InAppMessagesManager.kt

@@ -164,7 +164,7 @@ internal class InAppMessagesManager(
             // attempt to fetch messages from the backend (if we have the pre-requisite data already)
             val onesignalId = _userManager.onesignalId
             val updateConditionDeferred =
-                _consistencyManager.registerCondition(IamFetchReadyCondition(onesignalId))
+                _consistencyManager.getRywDataFromAwaitableCondition(IamFetchReadyCondition(onesignalId))
             val rywToken = updateConditionDeferred.await()
             if (rywToken != null) {
                 fetchMessages(rywToken)
@@ -241,7 +241,7 @@ internal class InAppMessagesManager(
         suspendifyOnThread {
             val onesignalId = _userManager.onesignalId
             val iamFetchCondition =
-                _consistencyManager.registerCondition(IamFetchReadyCondition(onesignalId))
+                _consistencyManager.getRywDataFromAwaitableCondition(IamFetchReadyCondition(onesignalId))
             val rywToken = iamFetchCondition.await()
 
             if (rywToken != null) {