Merge pull request http-rs#348 from Fishrock123/ci-improvements

ci: another round of improvements

Author: Fishrock123

.github/workflows/ci.yaml

@@ -8,9 +8,6 @@ on:
       - staging
       - trying
 
-env:
-  RUSTFLAGS: -Dwarnings
-
 jobs:
   build_and_test:
     name: Build and test
@@ -23,7 +20,7 @@ jobs:
     steps:
     - uses: actions/checkout@master
 
-    - name: Install ${{ matrix.rust }}
+    - name: Install ${{ matrix.rust }} toolchain
       uses: actions-rs/toolchain@v1
       with:
         toolchain: ${{ matrix.rust }}
@@ -33,13 +30,13 @@ jobs:
       uses: actions-rs/cargo@v1
       with:
         command: check
-        args: --workspace --benches --bins --examples --tests --features hyperium_http
+        args: --workspace --all-targets --features hyperium_http
 
     - name: check unstable
       uses: actions-rs/cargo@v1
       with:
         command: check
-        args: --workspace --benches --bins --examples --tests --features "hyperium_http,unstable"
+        args: --workspace --all-targets --features "hyperium_http,unstable"
 
     - name: tests
       uses: actions-rs/cargo@v1
@@ -53,31 +50,36 @@ jobs:
     steps:
     - uses: actions/checkout@master
 
+    - name: Install nightly toolchain
+      uses: actions-rs/toolchain@v1
+      with:
+        profile: minimal
+        toolchain: nightly
+        override: true
+        components: clippy, rustfmt
+
     - name: clippy
-      run: cargo clippy --workspace --benches --bins --examples --tests --features "hyperium_http,unstable" -- -D warnings
+      run: cargo clippy --workspace --all-targets --features "hyperium_http,unstable"
 
     - name: fmt
       run: cargo fmt --all -- --check
 
     - name: docs
       run: cargo doc --no-deps
 
-  # check_wasm:
-  #   name: Check wasm targets
-  #   runs-on: ubuntu-latest
-
-  #   steps:
-  #   - uses: actions/checkout@master
-
-  #   - name: Install nightly with wasm32-unknown-unknown
-  #     uses: actions-rs/toolchain@v1
-  #     with:
-  #       toolchain: nightly
-  #       target: wasm32-unknown-unknown
-  #       override: true
-
-  #   - name: check
-  #     uses: actions-rs/cargo@v1
-  #     with:
-  #       command: check
-  #       args: --target wasm32-unknown-unknown
+  check_wasm:
+    name: Check wasm targets
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@master
+
+    - name: Install nightly with wasm32-unknown-unknown
+      uses: actions-rs/toolchain@v1
+      with:
+        toolchain: nightly
+        target: wasm32-unknown-unknown
+        override: true
+
+    - name: check
+      run: cargo check --target wasm32-unknown-unknown --no-default-features --features=fs,serde

src/content/media_type_proposal.rs

@@ -57,7 +57,7 @@ impl MediaTypeProposal {
             .remove_param("q")
             .map(|param| param.as_str().parse())
             .transpose()?;
-        Ok(Self::new(media_type, weight)?)
+        Self::new(media_type, weight)
     }
 }
 

src/mime/constants.rs

@@ -20,12 +20,23 @@ macro_rules! mime_const {
     };
 
     (with_params, $name:ident, $desc:expr, $base:expr, $sub:expr, $is_utf8:expr, $doccomment:expr) => {
-        mime_const!(doc_expanded, $name, $desc, $base, $sub, $is_utf8,
-             concat!(
+        mime_const!(
+            doc_expanded,
+            $name,
+            $desc,
+            $base,
+            $sub,
+            $is_utf8,
+            concat!(
                 "Content-Type for ",
                 $desc,
                 ".\n\n# Mime Type\n\n```text\n",
-                $base, "/", $sub, $doccomment, "\n```")
+                $base,
+                "/",
+                $sub,
+                $doccomment,
+                "\n```"
+            )
         );
     };