Account for virtualedit=all in FixUsings

Fixes #731

Author: nickspoons

autoload/OmniSharp/buffer.vim

@@ -88,6 +88,7 @@ function! OmniSharp#buffer#Update(responseBody) abort
   let changes = get(a:responseBody, 'Changes', [])
   if type(changes) == type(v:null) | let changes = [] | endif
 
+  let virtualedit = &virtualedit ==? 'all'
   if len(changes)
     for change in changes
       let text = join(split(change.NewText, '\r\?\n', 1), "\n")
@@ -98,7 +99,7 @@ function! OmniSharp#buffer#Update(responseBody) abort
       let start = [change.StartLine, startCol]
       let end = [change.EndLine, endCol]
       call cursor(start)
-      if startCol > len(getline('.'))
+      if startCol > len(getline('.')) && !virtualedit
         " We can't set a mark after the last character of the line, so add an
         " extra charaqcter which will be immediately deleted again
         noautocmd normal! a<

test/fixusings.vader

@@ -46,6 +46,65 @@ Expect cs(should add required using):
   }
 
 
+Given cs():
+  using System;
+
+  public class Test
+  {
+    public Test()
+    {
+        Console.WriteLine(Encoding.UTF8.ToString());
+    }
+  }
+
+Execute (run fix usings):
+  call OmniSharpTestInitializeBuffer('FixUsings3')
+  call OmniSharpWarmup('OmniSharp#actions#usings#Fix', [])
+  call OmniSharpTestAwait('OmniSharp#actions#usings#Fix', [])
+
+Expect cs(should add another required using):
+  using System;
+  using System.Text;
+
+  public class Test
+  {
+    public Test()
+    {
+        Console.WriteLine(Encoding.UTF8.ToString());
+    }
+  }
+
+
+Given cs():
+  using System;
+
+  public class Test
+  {
+    public Test()
+    {
+        Console.WriteLine(Encoding.UTF8.ToString());
+    }
+  }
+
+Execute (run fix usings with virtualedit=all):
+  call OmniSharpTestInitializeBuffer('FixUsings4')
+  set virtualedit=all
+  call OmniSharpWarmup('OmniSharp#actions#usings#Fix', [])
+  call OmniSharpTestAwait('OmniSharp#actions#usings#Fix', [])
+
+Expect cs(should add another required using):
+  using System;
+  using System.Text;
+
+  public class Test
+  {
+    public Test()
+    {
+        Console.WriteLine(Encoding.UTF8.ToString());
+    }
+  }
+
+
 Given cs():
   public class test {
       class1 ns1 = new class1();
@@ -62,7 +121,7 @@ Given cs():
   }
 
 Execute (run fix usings):
-  call OmniSharpTestInitializeBuffer('FixUsings3')
+  call OmniSharpTestInitializeBuffer('FixUsings5')
   call OmniSharpWarmup('OmniSharp#actions#usings#Fix', [])
   call OmniSharpTestAwait('OmniSharp#actions#usings#Fix', [])
 
@@ -82,7 +141,7 @@ Expect cs(should not add ambiguous using):
   }
 
 Execute (should return ambiguous usings to Callback):
-  call OmniSharpTestInitializeBuffer('FixUsings4')
+  call OmniSharpTestInitializeBuffer('FixUsings6')
   call OmniSharpWarmup('OmniSharp#actions#usings#Fix', [])
   let g:OmniSharp_test_locations = []
   function! s:CallbackFixUsings(locations)
@@ -103,7 +162,7 @@ Execute (should return ambiguous usings to Callback):
   AssertEqual g:OmniSharp_test_locations[0].lnum, 2
 
 Execute (should add ambiguous usings to quickfix):
-  call OmniSharpTestInitializeBuffer('FixUsings5')
+  call OmniSharpTestInitializeBuffer('FixUsings7')
   call OmniSharpWarmup('OmniSharp#actions#usings#Fix', [])
   " Cannot use OmniSharpTestAwait, as the callback prevents the default quickfix
   " behaviour