Move log config variable parsing from plugin/OmniSharp.vim to autoload\OmniSharp\log.vim

Author: lrdickson

autoload/OmniSharp.vim

@@ -429,9 +429,9 @@ function! OmniSharp#Install(...) abort
   let l:http = g:OmniSharp_server_stdio ? '' : '-H'
   let l:version = a:0 > 0 ? '-v ' . shellescape(a:1) : ''
   let l:location = shellescape(OmniSharp#util#ServerDir())
+  let l:logfile = OmniSharp#log#GetLogDir() . '\install.log'
 
   if has('win32')
-    let l:logfile = g:OmniSharp_log_dir . '\install.log'
     let l:script = shellescape(
     \ s:plugin_root_dir . '\installer\omnisharp-manager.ps1')
     let l:version_file_location = l:location . '\OmniSharpInstall-version.txt'
@@ -440,7 +440,6 @@ function! OmniSharp#Install(...) abort
     \ 'powershell -ExecutionPolicy Bypass -File %s %s -l %s %s',
     \ l:script, l:http, l:location, l:version)
   else
-    let l:logfile = g:OmniSharp_log_dir . '/install.log'
     let l:script = shellescape(
     \ s:plugin_root_dir . '/installer/omnisharp-manager.sh')
     let l:mono = g:OmniSharp_server_use_mono ? '-M' : ''

autoload/OmniSharp/log.vim

@@ -1,7 +1,23 @@
 let s:save_cpo = &cpoptions
 set cpoptions&vim
 
-let s:stdiologfile = g:OmniSharp_log_dir . '/stdio.log'
+if has('win32')
+  let default_log_dir = expand('<sfile>:p:h:h:h') . '\log'
+else
+  let default_log_dir = expand('<sfile>:p:h:h:h') . '/log'
+end
+
+let s:logdir = get(g:, 'OmniSharp_log_dir', default_log_dir)
+let s:stdiologfile = s:logdir . '/stdio.log'
+
+" Make the log directory if it doesn't exist
+if !isdirectory(g:OmniSharp_log_dir)
+  call mkdir(g:OmniSharp_log_dir, 'p')
+end
+
+function! OmniSharp#log#GetLogDir() abort
+  return s:logdir
+endfunction
 
 " Log from OmniSharp-vim
 function! OmniSharp#log#Log(job, message, ...) abort

plugin/OmniSharp.vim

@@ -30,13 +30,6 @@ let g:OmniSharp_start_without_solution = get(g:, 'OmniSharp_start_without_soluti
 " Automatically start server
 let g:OmniSharp_start_server = get(g:, 'OmniSharp_start_server', get(g:, 'Omnisharp_start_server', 1))
 
-if has('win32')
-  let default_log_dir = expand('<sfile>:p:h:h') . '\log'
-else
-  let default_log_dir = expand('<sfile>:p:h:h') . '/log'
-end
-let g:OmniSharp_log_dir = get(g:, 'OmniSharp_log_dir', default_log_dir)
-
 let defaultlevel = g:OmniSharp_server_stdio ? 'info' : 'warning'
 let g:OmniSharp_loglevel = get(g:, 'OmniSharp_loglevel', defaultlevel)
 
@@ -137,9 +130,4 @@ if g:OmniSharp_selector_ui ==? 'ctrlp'
   endif
 endif
 
-" Make the log directory if it doesn't exist
-if !isdirectory(g:OmniSharp_log_dir)
-  call mkdir(g:OmniSharp_log_dir, "p")
-end
-
 " vim:et:sw=2:sts=2