Move ALE integration logic into autoload function

Author: nickspoons

autoload/ale/sources/OmniSharp.vim

@@ -1,10 +1,13 @@
-function! ale#sources#OmniSharp#WantResults(buffer) abort
-  let g:OmniSharp_diagnostics_requested = 1
+function! ale#sources#OmniSharp#WantResults() abort
+  if !g:OmniSharp_server_stdio | return | endif
+  let bufnr = g:ale_want_results_buffer
+  if getbufvar(bufnr, '&filetype') !=# 'cs' | return | endif
   if OmniSharp#FugitiveCheck() | return | endif
-  call ale#other_source#StartChecking(a:buffer, 'OmniSharp')
-  let opts = { 'BufNum': a:buffer }
+  let g:OmniSharp_diagnostics_requested = 1
+  call ale#other_source#StartChecking(bufnr, 'OmniSharp')
+  let opts = { 'BufNum': bufnr }
   let Callback = function('ale#sources#OmniSharp#ProcessResults', [opts])
-  call OmniSharp#actions#diagnostics#StdioCheck(a:buffer, Callback)
+  call OmniSharp#actions#diagnostics#StdioCheck(bufnr, Callback)
 endfunction
 
 function! ale#sources#OmniSharp#ProcessResults(opts, locations) abort

plugin/OmniSharp.vim

@@ -53,13 +53,6 @@ command! -bar -bang OmniSharpStatus call OmniSharp#Status(<bang>0)
 " Preserve backwards compatibility with older version g:OmniSharp_highlight_types
 let g:OmniSharp_highlighting = get(g:, 'OmniSharp_highlighting', get(g:, 'OmniSharp_highlight_types', 2))
 
-function! s:ALEWantResults() abort
-  if !g:OmniSharp_server_stdio | return | endif
-  if getbufvar(g:ale_want_results_buffer, '&filetype') ==# 'cs'
-    call ale#sources#OmniSharp#WantResults(g:ale_want_results_buffer)
-  endif
-endfunction
-
 augroup OmniSharp_Integrations
   autocmd!
 
@@ -82,7 +75,7 @@ augroup OmniSharp_Integrations
   \})
 
   " Listen for ALE requests
-  autocmd User ALEWantResults call s:ALEWantResults()
+  autocmd User ALEWantResults call ale#sources#OmniSharp#WantResults()
 augroup END
 
 if !exists('g:OmniSharp_selector_ui')