ci: make sure the build fails on failing unit tests

Also refactored tests

Author: foosel

.github/workflows/ci.yml

@@ -67,6 +67,7 @@ jobs:
       - name: 🚀 Run test suite
         run: |
           pytest | tee report.txt
+          pytest_exit=${PIPESTATUS[0]}
 
           # generate summary
           python=$(python -c 'import sys; print(".".join(map(str, sys.version_info[:3])))')
@@ -89,6 +90,9 @@ jobs:
           </details>
           EOF
 
+          # make sure we fail if pytest fails!
+          exit $pytest_exit
+
   test-install:
     name: 🧪 Installation test
     strategy:

tests/_files/pyproject-toml-only/pyproject.toml renamed to tests/_files/pyproject-toml-only/input/pyproject.toml

@@ -0,0 +1,4 @@
+include README.md
+recursive-include octoprint_requestspinner/templates *
+recursive-include octoprint_requestspinner/translations *
+recursive-include octoprint_requestspinner/static *

tests/_files/setup-py-and-pyproject-toml/expected/MANIFEST.in

@@ -0,0 +1,87 @@
+
+# Taskfile to be used with task: https://taskfile.dev
+#
+# A copy of task gets automatically installed as a "develop" dependency this plugin:
+#
+#   pip install .[develop]
+#   go-task --list-all
+#
+
+version: "3"
+
+env:
+    LOCALES: []  # list your included locales here, e.g. ["de", "fr"]
+    TRANSLATIONS: "octoprint_requestspinner/translations"  # translations folder
+
+
+tasks:
+    install:
+        desc: Installs the plugin into the current venv
+        cmds:
+          - "python -m pip install -e .[develop]"
+
+    ### Build related
+
+    build:
+        desc: Builds sdist & wheel
+        cmds:
+          - python -m build --sdist --wheel
+
+    build-sdist:
+        desc: Builds sdist
+        cmds:
+          - python -m build --sdist
+
+    build-wheel:
+        desc: Builds wheel
+        cmds:
+          - python -m build --wheel
+
+    ### Translation related
+
+    babel-new:
+        desc: Create a new translation for a locale
+        cmds:
+          - task: babel-extract
+          - pybabel init --input-file=translations/messages.pot --output-dir=translations --locale="{{ .CLI_ARGS }}"
+
+    babel-extract:
+        desc: Update pot file from source
+        cmds:
+          - pybabel extract --mapping-file=babel.cfg --output-file=translations/messages.pot --msgid-bugs-address=i18n@octoprint.org --copyright-holder="The OctoPrint Project" .
+
+    babel-update:
+        desc: Update translation files from pot file
+        cmds:
+          - for:
+                var: LOCALES
+            cmd: pybabel update --input-file=translations/messages.pot --output-dir=translations --locale={{ .ITEM }}
+
+    babel-refresh:
+        desc: Update translation files from source
+        cmds:
+          - task: babel-extract
+          - task: babel-update
+
+    babel-compile:
+        desc: Compile translation files
+        cmds:
+          - pybabel compile --directory=translations
+
+    babel-bundle:
+        desc: Bundle translations
+        preconditions:
+          - test -d {{ .TRANSLATIONS }}
+        cmds:
+          - for:
+               var: LOCALES
+            cmd: |
+                locale="{{ .ITEM }}"
+                source="translations/${locale}"
+                target="{{ .TRANSLATIONS }}/${locale}"
+
+                [ ! -d "${target}" ] || rm -r "${target}"
+
+                echo "Copying translations for locale ${locale} from ${source} to ${target}..."
+                cp -r "${source}" "${target}"
+

tests/_files/setup-py-and-pyproject-toml/README.md renamed to tests/_files/setup-py-and-pyproject-toml/expected/README.md

@@ -0,0 +1,117 @@
+[build-system]
+requires = [
+    "setuptools>=68",
+]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "OctoPrint-RequestSpinner"
+version = "0.2.0"
+description = "Shows a little spinner in the web frontend when background requests are active"
+authors = [
+    { name = "Gina Häußge", email = "osd@foosel.net" },
+]
+requires-python = ">=3.7,<4"
+dependencies = []
+dynamic = [
+    "license",
+]
+
+[project.entry-points."octoprint.plugin"]
+requestspinner = "octoprint_requestspinner"
+
+[project.urls]
+Homepage = "https://github.com/OctoPrint/OctoPrint-RequestSpinner"
+
+[project.optional-dependencies]
+develop = [
+    "go-task-bin",
+]
+
+[project.readme]
+file = "README.md"
+content-type = "text/markdown"
+
+[tool.setuptools]
+include-package-data = true
+
+[tool.setuptools.packages.find]
+include = [
+    "octoprint_requestspinner",
+    "octoprint_requestspinner.*",
+]
+
+[tool.ruff]
+exclude = [
+    ".bzr",
+    ".direnv",
+    ".eggs",
+    ".git",
+    ".git-rewrite",
+    ".hg",
+    ".ipynb_checkpoints",
+    ".mypy_cache",
+    ".nox",
+    ".pants.d",
+    ".pyenv",
+    ".pytest_cache",
+    ".pytype",
+    ".ruff_cache",
+    ".svn",
+    ".tox",
+    ".venv",
+    ".vscode",
+    "__pypackages__",
+    "_build",
+    "buck-out",
+    "build",
+    "dist",
+    "node_modules",
+    "site-packages",
+    "venv",
+]
+line-length = 90
+indent-width = 4
+target-version = "py37"
+
+[tool.ruff.lint]
+select = [
+    "B",
+    "C",
+    "E",
+    "F",
+    "I",
+    "W",
+    "B9",
+]
+ignore = [
+    "E203",
+    "E231",
+    "E265",
+    "E266",
+    "E402",
+    "E501",
+    "E731",
+    "E741",
+    "W605",
+    "C901",
+]
+fixable = [
+    "I",
+    "C4",
+    "E",
+]
+dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"
+
+[tool.ruff.lint.isort]
+known-first-party = [
+    "octoprint_file_check",
+]
+
+[tool.ruff.format]
+quote-style = "double"
+indent-style = "space"
+skip-magic-trailing-comma = false
+line-ending = "lf"
+docstring-code-format = false
+docstring-code-line-length = "dynamic"

tests/_files/setup-py-and-pyproject-toml/expected/Taskfile.yml

@@ -0,0 +1,6 @@
+
+import setuptools
+
+# we define the license string like this to be backwards compatible to setuptools<77
+setuptools.setup(license="AGPL-3.0-or-later")
+