Merge pull request #155 from georges-hatem/main

micro-optimizations

Author: gcarreno

entries/ghatem-fpc/src/OneBRC-dirty.lpr

@@ -205,13 +205,13 @@ procedure TBRCDictionary.InternalFind(const aKey: Cardinal; out aFound: Boolean;
         // found match
         aIndex := vIdx;
         aFound := True;
-        break;
+        exit;
       end;
       if FHashes[vIdx] = 0 then begin
         // found empty bucket to use
         aIndex := vIdx;
         aFound := False;
-        break;
+        exit;
       end;
     end;
   end;
@@ -263,12 +263,8 @@ function RoundExInteger (const aTemp: Double): Integer; inline;
 { TOneBRC }
 
 function Compare(AList: TStringList; AIndex1, AIndex2: Integer): Integer;
-var
-  Str1, Str2: String;
 begin
-  Str1 := AList.Strings[AIndex1];
-  Str2 := AList.Strings[AIndex2];
-  Result := CompareStr(Str1, Str2);
+  Result := CompareStr(AList.Strings[AIndex1], AList.Strings[AIndex2]);
 end;
 
 procedure TOneBRC.ExtractLineData(const aStart: Int64; const aEnd: Int64; out aLength: ShortInt; out aTemp: SmallInt);
@@ -285,8 +281,7 @@ procedure TOneBRC.ExtractLineData(const aStart: Int64; const aEnd: Int64; out aL
 
   if FData[J] <> ';' then begin
     Dec (J);
-    if FData[J] <> ';' then
-      Dec(J);
+    Dec (J, Ord (FData[J] <> ';'));
   end;
   // I is the position of the semi-colon, extract what's before and after it
 
@@ -386,9 +381,8 @@ procedure TOneBRC.ProcessData (aThreadNb: TThreadCount; aStartIdx: Int64; aEndId
   vFound: Boolean;
 begin
   for I := 0 to cNumStations - 1 do begin
-    vData := @FDictionary.FThreadData[aThreadNb][I];
-    vData^.Max := -2000;
-    vData^.Min := 2000;
+    FDictionary.FThreadData[aThreadNb][I].Max := -2000;
+    FDictionary.FThreadData[aThreadNb][I].Min := 2000;
   end;
 
   i := aStartIdx;
@@ -527,7 +521,6 @@ procedure TOneBRC.GenerateOutput;
         vStations.Add(iStationName);
     end;
     vStations.EndUpdate;
-    //vStations.AddStrings(FDictionary.FStationNames);
     vStations.CustomSort (@Compare);
 
     I := 0;