query and querystring are mutually exclusive; disallow more than one querystring

Author: karenetheridge

src/schemas/validation/schema.yaml

@@ -236,9 +236,7 @@ $defs:
         items:
           $ref: '#/$defs/server'
       parameters:
-        type: array
-        items:
-          $ref: '#/$defs/parameter-or-reference'
+        $ref: '#/$defs/parameters'
       additionalOperations:
         type: object
         additionalProperties:
@@ -295,9 +293,7 @@ $defs:
       operationId:
         type: string
       parameters:
-        type: array
-        items:
-          $ref: '#/$defs/parameter-or-reference'
+        $ref: '#/$defs/parameters'
       requestBody:
         $ref: '#/$defs/request-body-or-reference'
       responses:
@@ -334,6 +330,36 @@ $defs:
     $ref: '#/$defs/specification-extensions'
     unevaluatedProperties: false
 
+  parameters:
+    type: array
+    items:
+      $ref: '#/$defs/parameter-or-reference'
+    not:
+      allOf:
+        - contains:
+            type: object
+            properties:
+              in:
+                const: query
+            required:
+              - in
+        - contains:
+            type: object
+            properties:
+              in:
+                const: querystring
+            required:
+              - in
+    contains:
+      type: object
+      properties:
+        in:
+          const: querystring
+      required:
+        - in
+    minContains: 0
+    maxContains: 1
+
   parameter:
     $comment: https://spec.openapis.org/oas/v3.2#parameter-object
     type: object

tests/schema/fail/operation-object-query-with-querystring.yaml

@@ -0,0 +1,20 @@
+openapi: 3.2.0
+info:
+  title: API
+  version: 1.0.0
+components:
+  pathItems:
+    my-path-item:
+      get:
+        description: a query parameter cannot be used together with a querystring parameter
+        parameters:
+          - name: myquerystring
+            in: querystring
+            content:
+              application/json:
+                schema:
+                  type: string
+          - name: myquery
+            in: query
+            schema:
+              type: string

tests/schema/fail/operation-object-two-querystrings.yaml

@@ -0,0 +1,20 @@
+openapi: 3.2.0
+info:
+  title: API
+  version: 1.0.0
+components:
+  pathItems:
+    my-path-item:
+      get:
+        description: querystring cannot be used twice
+        parameters:
+          - name: myquerystring1
+            in: querystring
+            content:
+              application/json:
+                schema: {}
+          - name: myquerystring2
+            in: querystring
+            content:
+              application/json:
+                schema: {}

tests/schema/fail/path-item-object-query-with-querystring.yaml

@@ -0,0 +1,19 @@
+openapi: 3.2.0
+info:
+  title: API
+  version: 1.0.0
+components:
+  pathItems:
+    my-path-item:
+      parameters:
+        - name: myquerystring
+          in: querystring
+          content:
+            application/json:
+              schema:
+                type: string
+        - name: myquery
+          in: query
+          schema:
+            type: string
+      get: {}

tests/schema/fail/path-item-object-two-querystrings.yaml

@@ -0,0 +1,20 @@
+openapi: 3.2.0
+info:
+  title: API
+  version: 1.0.0
+components:
+  pathItems:
+    my-path-item:
+      description: querystring cannot be used twice
+      parameters:
+        - name: myquerystring1
+          in: querystring
+          content:
+            application/json:
+              schema: {}
+        - name: myquerystring2
+          in: querystring
+          content:
+            application/json:
+              schema: {}
+      get: {}