Merge pull request #8 from NullVoxPopuli/ensure-no-deprecations

Ensure no deprecations

Author: NullVoxPopuli

pnpm-lock.yaml

@@ -1,9 +1,14 @@
 import Application from '@ember/application';
+import { importSync, isDevelopingApp, macroCondition } from '@embroider/macros';
 
 import loadInitializers from 'ember-load-initializers';
 import Resolver from 'ember-resolver';
 import config from 'test-app/config/environment';
 
+if (macroCondition(isDevelopingApp())) {
+  importSync('test-app/deprecation-workflow');
+}
+
 export default class App extends Application {
   modulePrefix = config.modulePrefix;
   podModulePrefix = config.podModulePrefix;

test-app-ember-resources-7/app/app.ts

@@ -0,0 +1,23 @@
+import { registerDeprecationHandler } from '@ember/debug';
+
+import config from 'test-app/config/environment';
+
+const SHOULD_THROW = config.environment !== 'production';
+const SILENCED_DEPRECATIONS: string[] = [
+  // Add ids of deprecations you temporarily want to silence here.
+];
+
+registerDeprecationHandler((message, options, next) => {
+  if (!options) {
+    console.error('Missing options');
+    throw new Error(message);
+  }
+
+  if (SILENCED_DEPRECATIONS.includes(options.id)) {
+    return;
+  } else if (SHOULD_THROW) {
+    throw new Error(message);
+  }
+
+  next(message, options);
+});

test-app-ember-resources-7/app/deprecation-workflow.ts

@@ -45,7 +45,7 @@
     "@babel/eslint-parser": "^7.19.1",
     "@ember/optional-features": "^2.0.0",
     "@ember/string": "^3.0.1",
-    "@ember/test-helpers": "^3.0.3",
+    "@ember/test-helpers": "^3.2.1",
     "@embroider/compat": "^3.1.5",
     "@embroider/core": "^3.1.3",
     "@embroider/test-setup": "^3.0.1",

test-app-ember-resources-7/package.json

@@ -1,9 +1,14 @@
 import Application from '@ember/application';
+import { importSync, isDevelopingApp, macroCondition } from '@embroider/macros';
 
 import loadInitializers from 'ember-load-initializers';
 import Resolver from 'ember-resolver';
 import config from 'test-app/config/environment';
 
+if (macroCondition(isDevelopingApp())) {
+  importSync('test-app/deprecation-workflow');
+}
+
 export default class App extends Application {
   modulePrefix = config.modulePrefix;
   podModulePrefix = config.podModulePrefix;

test-app/app/app.ts

@@ -0,0 +1,23 @@
+import { registerDeprecationHandler } from '@ember/debug';
+
+import config from 'test-app/config/environment';
+
+const SHOULD_THROW = config.environment !== 'production';
+const SILENCED_DEPRECATIONS: string[] = [
+  // Add ids of deprecations you temporarily want to silence here.
+];
+
+registerDeprecationHandler((message, options, next) => {
+  if (!options) {
+    console.error('Missing options');
+    throw new Error(message);
+  }
+
+  if (SILENCED_DEPRECATIONS.includes(options.id)) {
+    return;
+  } else if (SHOULD_THROW) {
+    throw new Error(message);
+  }
+
+  next(message, options);
+});

test-app/app/deprecation-workflow.ts

@@ -45,7 +45,7 @@
     "@babel/eslint-parser": "^7.19.1",
     "@ember/optional-features": "^2.0.0",
     "@ember/string": "^3.0.1",
-    "@ember/test-helpers": "^3.0.3",
+    "@ember/test-helpers": "^3.2.1",
     "@embroider/compat": "^3.1.5",
     "@embroider/core": "^3.1.3",
     "@embroider/test-setup": "^3.0.1",