-
Notifications
You must be signed in to change notification settings - Fork 495
clarified instructions for certificates stored in hardware #3276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The documentation says to export the certificate, but this introduces errors when the certificate is stored in a hardware token. You just need to specify the certificate fingerprint, no need to export. See issue dotnet/runtime#100414
|
@dotnet-policy-service agree company="Kolver" |
|
Learn Build status updates of commit ccd1e10: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
better phrasing Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
|
Learn Build status updates of commit 9619cec: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Why isn't this merged already? It's a super simple but helpful documentation update |
Starting with .NET 9 and NuGet.exe 6.12, NU3043 warning is raised when a SHA-1 certificate fingerprint is passed to the sign commands. SHA-1 is considered insecure and should no longer be used. This warning is promoted to an error in the .NET 10 SDK, and will be promoted to an error in NuGet.exe around .NET 10's release. Co-authored-by: Kartheek Penagamuri <52756182+kartheekp-ms@users.noreply.github.com>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 027ee1d: ✅ Validation status: passed
For more details, please refer to the build report. |
The documentation says to export the certificate, but this introduces errors when the certificate is stored in a hardware token. You just need to specify the certificate fingerprint, no need to export. See issue dotnet/runtime#100414