chore: use standard 10 and Buffer.from

Author: BridgeAR

benchmark/index.js

@@ -10,23 +10,23 @@ const HiredisParser = require('../test/hiredis')
 function returnError (error) {}
 function checkReply (error, res) {}
 
-const startBuffer = new Buffer('$100\r\nabcdefghij')
-const chunkBuffer = new Buffer('abcdefghijabcdefghijabcdefghij')
-const stringBuffer = new Buffer('+testing a simple string\r\n')
-const integerBuffer = new Buffer(':1237884\r\n')
-const bigIntegerBuffer = new Buffer(':184467440737095516171234567890\r\n') // 2^64 + 1
-const errorBuffer = new Buffer('-Error ohnoesitbroke\r\n')
-const endBuffer = new Buffer('\r\n')
+const startBuffer = Buffer.from('$100\r\nabcdefghij')
+const chunkBuffer = Buffer.from('abcdefghijabcdefghijabcdefghij')
+const stringBuffer = Buffer.from('+testing a simple string\r\n')
+const integerBuffer = Buffer.from(':1237884\r\n')
+const bigIntegerBuffer = Buffer.from(':184467440737095516171234567890\r\n') // 2^64 + 1
+const errorBuffer = Buffer.from('-Error ohnoesitbroke\r\n')
+const endBuffer = Buffer.from('\r\n')
 const lorem = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, ' +
   'sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. ' +
   'Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ' +
   'ut aliquip ex ea commodo consequat. Duis aute irure dolor in' // 256 chars
 const bigStringArray = (new Array(Math.pow(2, 16) / lorem.length).join(lorem + ' ')).split(' ') // Math.pow(2, 16) chars long
-const startBigBuffer = new Buffer('$' + (4 * 1024 * 1024) + '\r\n')
+const startBigBuffer = Buffer.from('$' + (4 * 1024 * 1024) + '\r\n')
 
 const chunks = new Array(64)
 for (var i = 0; i < 64; i++) {
-  chunks[i] = new Buffer(bigStringArray.join(' ') + '.') // Math.pow(2, 16) chars long
+  chunks[i] = Buffer.from(bigStringArray.join(' ') + '.') // Math.pow(2, 16) chars long
 }
 
 const arraySize = 100
@@ -38,24 +38,24 @@ for (i = 0; i < arraySize; i++) {
   array += size + '\r\n' + lorem.slice(0, size) + '\r\n'
 }
 
-const arrayBuffer = new Buffer(array)
+const arrayBuffer = Buffer.from(array)
 
 const bigArraySize = 160
-const bigArrayChunks = [new Buffer('*1\r\n*1\r\n*' + bigArraySize)]
+const bigArrayChunks = [Buffer.from('*1\r\n*1\r\n*' + bigArraySize)]
 for (i = 0; i < bigArraySize; i++) {
   // A chunk has a maximum size of 2^16 bytes.
   size = 65000 + i
   if (i % 2) {
     // The "x" in the beginning is important to prevent benchmark manipulation due to a minor jsparser optimization
-    bigArrayChunks.push(new Buffer('x\r\n$' + size + '\r\n' + Array(size + 1).join('a') + '\r\n:' + (Math.random() * 1000000 | 0)))
+    bigArrayChunks.push(Buffer.from('x\r\n$' + size + '\r\n' + Array(size + 1).join('a') + '\r\n:' + (Math.random() * 1000000 | 0)))
   } else {
-    bigArrayChunks.push(new Buffer('\r\n+this is some short text about nothing\r\n:' + size + '\r\n$' + size + '\r\n' + Array(size).join('b')))
+    bigArrayChunks.push(Buffer.from('\r\n+this is some short text about nothing\r\n:' + size + '\r\n$' + size + '\r\n' + Array(size).join('b')))
   }
 }
-bigArrayChunks.push(new Buffer('\r\n'))
+bigArrayChunks.push(Buffer.from('\r\n'))
 
-const chunkedStringPart1 = new Buffer('+foobar')
-const chunkedStringPart2 = new Buffer('bazEND\r\n')
+const chunkedStringPart1 = Buffer.from('+foobar')
+const chunkedStringPart2 = Buffer.from('bazEND\r\n')
 
 const options = {
   returnReply: checkReply,

package.json

@@ -35,7 +35,7 @@
     "hiredis": "^0.5.0",
     "istanbul": "^0.4.0",
     "mocha": "^3.1.2",
-    "standard": "^9.0.0"
+    "standard": "^10.0.0"
   },
   "author": "Ruben Bridgewater",
   "license": "MIT",

test/errors.spec.js

@@ -11,7 +11,7 @@ describe('errors', function () {
   it('errors should have a stack trace with error message', function () {
     const err1 = new RedisError('test')
     const err2 = new ReplyError('test')
-    const err3 = new ParserError('test', new Buffer(''), 0)
+    const err3 = new ParserError('test', Buffer.from(''), 0)
     assert(err1.stack)
     assert(err2.stack)
     assert(err3.stack)