chore: keep Node.js v.4 support

Author: BridgeAR

.travis.yml

@@ -9,6 +9,7 @@ addons:
     packages:
     - g++-4.8
 node_js:
+  - "4"
   - "6"
   - "7"
 install:

benchmark/index.js

@@ -5,6 +5,7 @@
 const Benchmark = require('benchmark')
 const suite = new Benchmark.Suite()
 const Parser = require('./../')
+const Buffer = require('safe-buffer').Buffer
 const HiredisParser = require('../test/hiredis')
 
 function returnError (error) {}

lib/parser.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const Buffer = require('safe-buffer').Buffer
 const StringDecoder = require('string_decoder').StringDecoder
 const decoder = new StringDecoder()
 const errors = require('redis-errors')
@@ -424,15 +425,18 @@ function concatBulkBuffer (parser) {
  * @constructor
  */
 class JavascriptRedisParser {
-  constructor ({ returnReply, returnError, returnFatalError, returnBuffers, stringNumbers }) {
-    if (typeof returnError !== 'function' || typeof returnReply !== 'function') {
+  constructor (options) {
+    if (!options) {
+      throw new TypeError('Options are mandatory.')
+    }
+    if (typeof options.returnError !== 'function' || typeof options.returnReply !== 'function') {
       throw new TypeError('The returnReply and returnError options have to be functions.')
     }
-    this.setReturnBuffers(returnBuffers)
-    this.setStringNumbers(stringNumbers)
-    this.returnError = returnError
-    this.returnFatalError = returnFatalError || returnError
-    this.returnReply = returnReply
+    this.setReturnBuffers(!!options.returnBuffers)
+    this.setStringNumbers(!!options.stringNumbers)
+    this.returnError = options.returnError
+    this.returnFatalError = options.returnFatalError || options.returnError
+    this.returnReply = options.returnReply
     this.reset()
   }
 
@@ -458,7 +462,7 @@ class JavascriptRedisParser {
    * @param returnBuffers
    * @returns {undefined}
    */
-  setReturnBuffers (returnBuffers = false) {
+  setReturnBuffers (returnBuffers) {
     if (typeof returnBuffers !== 'boolean') {
       throw new TypeError('The returnBuffers argument has to be a boolean')
     }
@@ -471,7 +475,7 @@ class JavascriptRedisParser {
    * @param stringNumbers
    * @returns {undefined}
    */
-  setStringNumbers (stringNumbers = false) {
+  setStringNumbers (stringNumbers) {
     if (typeof stringNumbers !== 'boolean') {
       throw new TypeError('The stringNumbers argument has to be a boolean')
     }

package.json

@@ -30,7 +30,8 @@
     "node": ">=6"
   },
   "dependencies": {
-    "redis-errors": "^1.0.0"
+    "redis-errors": "^1.0.0",
+    "safe-buffer": "^5.0.1"
   },
   "devDependencies": {
     "benchmark": "^2.1.0",

test/parsers.spec.js

@@ -5,6 +5,7 @@
 
 const assert = require('assert')
 const util = require('util')
+const Buffer = require('safe-buffer').Buffer
 const JavascriptParser = require('../')
 const HiredisParser = require('./hiredis')
 const errors = require('redis-errors')