chore: inline function

Author: BridgeAR

lib/parser.js

@@ -76,26 +76,6 @@ function parseStringNumbers (parser) {
   }
 }
 
-/**
- * Returns a string or buffer of the provided offset start and
- * end ranges. Checks `optionReturnBuffers`.
- *
- * If returnBuffers is active, all return values are returned as buffers besides numbers and errors
- *
- * @param parser
- * @param start
- * @param end
- * @returns {*}
- */
-function convertBufferRange (parser, start, end) {
-  parser.offset = end + 2
-  if (parser.optionReturnBuffers === true) {
-    return parser.buffer.slice(start, end)
-  }
-
-  return parser.buffer.toString('utf8', start, end)
-}
-
 /**
  * Parse a '+' redis simple string response but forward the offsets
  * onto convertBufferRange to generate a string.
@@ -110,7 +90,11 @@ function parseSimpleString (parser) {
 
   while (offset < length) {
     if (buffer[offset++] === 13) { // \r\n
-      return convertBufferRange(parser, start, offset - 1)
+      parser.offset = offset + 1
+      if (parser.optionReturnBuffers === true) {
+        return parser.buffer.slice(start, offset - 1)
+      }
+      return parser.buffer.toString('utf8', start, offset - 1)
     }
   }
 }
@@ -173,8 +157,12 @@ function parseBulkString (parser) {
     parser.bufferCache.push(parser.buffer)
     return
   }
-
-  return convertBufferRange(parser, parser.offset, offsetEnd)
+  const start = parser.offset
+  parser.offset = offsetEnd + 2
+  if (parser.optionReturnBuffers === true) {
+    return parser.buffer.slice(start, offsetEnd)
+  }
+  return parser.buffer.toString('utf8', start, offsetEnd)
 }
 
 /**

test/parsers.spec.js

@@ -69,8 +69,8 @@ describe('parsers', function () {
       parser.execute(Buffer.from('+test'))
       parser.setReturnBuffers(true)
       assert.strictEqual(replyCount, 1)
-      parser.execute(Buffer.from('\r\n'))
-      assert.strictEqual(replyCount, 2)
+      parser.execute(Buffer.from('\r\n$4\r\ntest\r\n'))
+      assert.strictEqual(replyCount, 3)
     })
 
     it('reset returnBuffers option with wrong input', function () {