Minimal improvement

Author: Ruben Bridgewater

lib/parser.js

@@ -38,7 +38,8 @@ function parseSimpleNumbers (parser) {
 /**
  * Used for integer numbers in case of the returnNumbers option
  *
- * The maximimum possible integer to use is: Math.floor(Number.MAX_SAFE_INTEGER / 10) - 9
+ * The maximimum possible integer to use is: Math.floor(Number.MAX_SAFE_INTEGER / 10)
+ * Staying in a SMI Math.floor((Math.pow(2, 32) / 10) - 1) is even more efficient though
  *
  * @param parser
  * @returns {*}
@@ -62,9 +63,8 @@ function parseStringNumbers (parser) {
         res += number
       }
       return res
-    } else if (number > 900719925474090) {
-      res += number
-      res += c1 - 48
+    } else if (number > 429496728) {
+      res += (number * 10) + (c1 - 48)
       number = 0
     } else if (c1 === 48 && number === 0) {
       res += 0
@@ -102,9 +102,9 @@ function convertBufferRange (parser, start, end) {
  */
 function parseSimpleStringViaOffset (parser) {
   var start = parser.offset
-  var offset = parser.offset
-  var length = parser.buffer.length - 1
+  var offset = start
   var buffer = parser.buffer
+  var length = buffer.length - 1
 
   while (offset < length) {
     if (buffer[offset++] === 13) { // \r\n
@@ -121,7 +121,7 @@ function parseSimpleStringViaOffset (parser) {
 function parseLength (parser) {
   var string = parseSimpleNumbers(parser)
   if (string !== undefined) {
-    return +string
+    return string
   }
 }
 

test/parsers.spec.js

@@ -541,7 +541,7 @@ describe('parsers', function () {
           return this.skip()
         }
         var replyCount = 0
-        var entries = ['123', '590295810358705700002', '-99999999999999999', '9007199254740992', '90071992547409920', '10000040000000000000000000000000000000020']
+        var entries = ['123', '590295810358705700002', '-99999999999999999', '4294967290', '90071992547409920', '10000040000000000000000000000000000000020']
         function checkReply (reply) {
           assert.strictEqual(typeof reply, 'string')
           assert.strictEqual(reply, entries[replyCount])
@@ -551,7 +551,7 @@ describe('parsers', function () {
           returnReply: checkReply,
           stringNumbers: true
         })
-        parser.execute(new Buffer(':123\r\n:590295810358705700002\r\n:-99999999999999999\r\n:9007199254740992\r\n:90071992547409920\r\n:10000040000000000000000000000000000000020\r\n'))
+        parser.execute(new Buffer(':123\r\n:590295810358705700002\r\n:-99999999999999999\r\n:4294967290\r\n:90071992547409920\r\n:10000040000000000000000000000000000000020\r\n'))
         assert.strictEqual(replyCount, 6)
       })