Merge pull request #28 from CKarper/RedisError

feat: Add top level error type

Author: BridgeAR

index.js

@@ -2,3 +2,4 @@
 
 module.exports = require('./lib/parser')
 module.exports.ReplyError = require('./lib/replyError')
+module.exports.RedisError = require('./lib/redisError')

lib/redisError.js

@@ -0,0 +1,21 @@
+'use strict'
+
+var util = require('util')
+
+function RedisError (message) {
+  Error.call(this, message)
+  Error.captureStackTrace(this, this.constructor)
+  Object.defineProperty(this, 'message', {
+    value: message || '',
+    writable: true
+  })
+}
+
+util.inherits(RedisError, Error)
+
+Object.defineProperty(RedisError.prototype, 'name', {
+  value: 'RedisError',
+  writable: true
+})
+
+module.exports = RedisError

lib/replyError.js

@@ -1,20 +1,16 @@
 'use strict'
 
 var util = require('util')
+var RedisError = require('./redisError')
 
 function ReplyError (message, newLimit) {
   var limit = Error.stackTraceLimit
   Error.stackTraceLimit = newLimit || 2
-  Error.call(this, message)
-  Error.captureStackTrace(this, this.constructor)
+  RedisError.call(this, message)
   Error.stackTraceLimit = limit
-  Object.defineProperty(this, 'message', {
-    value: message || '',
-    writable: true
-  })
 }
 
-util.inherits(ReplyError, Error)
+util.inherits(ReplyError, RedisError)
 
 Object.defineProperty(ReplyError.prototype, 'name', {
   value: 'ReplyError',

test/parsers.spec.js

@@ -6,6 +6,7 @@ var assert = require('assert')
 var JavascriptParser = require('../')
 var HiredisParser = require('../lib/hiredis')
 var ReplyError = JavascriptParser.ReplyError
+var RedisError = JavascriptParser.RedisError
 var parsers = [HiredisParser, JavascriptParser]
 
 // Mock the not needed return functions
@@ -320,6 +321,7 @@ describe('parsers', function () {
           assert.strictEqual(typeof this.log, 'function')
           assert.strictEqual(err.message, 'Protocol error, got "a" as reply type byte')
           assert.strictEqual(err.name, 'ReplyError')
+          assert(err instanceof RedisError)
           assert(err instanceof ReplyError)
           assert(err instanceof Error)
           replyCount++