Merge pull request #210 from baronha/feat/nitro-20

✨ feat: Nitro 20

Author: baronha

android/src/main/java/com/margelo/nitro/multipleimagepicker/MultipleImagePicker.kt

@@ -11,7 +11,7 @@ class MultipleImagePicker : HybridMultipleImagePickerSpec() {
 
     override fun openPicker(
         config: NitroConfig,
-        resolved: (result: Array<Result>) -> Unit,
+        resolved: (result: Array<PickerResult>) -> Unit,
         rejected: (reject: Double) -> Unit
     ) {
         pickerModule.openPicker(config, resolved, rejected)

android/src/main/java/com/margelo/nitro/multipleimagepicker/MultipleImagePickerImp.kt

@@ -60,7 +60,7 @@ class MultipleImagePickerImp(reactContext: ReactApplicationContext?) :
     @ReactMethod
     fun openPicker(
         options: NitroConfig,
-        resolved: (result: Array<Result>) -> Unit,
+        resolved: (result: Array<PickerResult>) -> Unit,
         rejected: (reject: Double) -> Unit
     ) {
         PictureAppMaster.getInstance().app = this
@@ -150,7 +150,7 @@ class MultipleImagePickerImp(reactContext: ReactApplicationContext?) :
             .isPreviewFullScreenMode(true)
             .forResult(object : OnResultCallbackListener<LocalMedia?> {
                 override fun onResult(localMedia: ArrayList<LocalMedia?>?) {
-                    var data: Array<Result> = arrayOf()
+                    var data: Array<PickerResult> = arrayOf()
                     if (localMedia?.size == 0 || localMedia == null) {
                         resolved(arrayOf())
                         return
@@ -575,7 +575,7 @@ class MultipleImagePickerImp(reactContext: ReactApplicationContext?) :
         }.toMutableList()
     }
 
-    private fun getResult(item: LocalMedia): Result {
+    private fun getResult(item: LocalMedia): PickerResult {
 
         val type: ResultType =
             if (item.mimeType.startsWith("video/")) ResultType.VIDEO else ResultType.IMAGE
@@ -597,7 +597,7 @@ class MultipleImagePickerImp(reactContext: ReactApplicationContext?) :
         if (!path.startsWith("file://") && !path.startsWith("content://") && type == ResultType.IMAGE)
             path = "file://$path"
 
-        val media = Result(
+        val media = PickerResult(
             localIdentifier = item.id.toString(),
             width,
             height,

docs/docs/GETTING_STARTED.mdx

@@ -50,7 +50,7 @@ Install [@baronha/react-native-multiple-image-picker](https://www.npmjs.com/pack
 
 ```bash
 yarn add @baronha/react-native-multiple-image-picker
-yarn add -D react-native-nitro-modules@0.18.2
+yarn add -D react-native-nitro-modules@0.20.1
 cd ios && pod install
 ```
 
@@ -60,7 +60,7 @@ cd ios && pod install
 
 ```bash
 npx expo install @baronha/react-native-multiple-image-picker 
-npx expo install react-native-nitro-modules@0.18.2 -- --dev
+npx expo install react-native-nitro-modules@0.20.1 -- --dev
 npx expo prebuild
 ```
 

example/package.json

@@ -1,6 +1,6 @@
 {
   "name": "multipleimagepickerexample",
-  "version": "2.0.4",
+  "version": "2.1.2",
   "main": "expo/AppEntry.js",
   "scripts": {
     "start": "expo start",
@@ -31,7 +31,7 @@
     "@react-native/typescript-config": "0.75.2",
     "@types/react": "~18.2.45",
     "react-native-builder-bob": "^0.30.0",
-    "react-native-nitro-modules": "0.18.2",
+    "react-native-nitro-modules": "^0.20.1",
     "typescript": "^5.1.3"
   },
   "private": true

example/src/index.tsx

@@ -17,7 +17,7 @@ import { StyleSheet } from 'react-native'
 import ImageGrid from '@baronha/react-native-image-grid'
 import {
   openPicker,
-  Result,
+  PickerResult,
   defaultOptions,
   Config,
   openCropper,
@@ -64,7 +64,7 @@ const parseNumber = (value: string): number | undefined => {
 
 export default function App() {
   const { background, foreground } = useTheme()
-  const [images, setImages] = useState<Result[]>([])
+  const [images, setImages] = useState<PickerResult[]>([])
   const [options, changeOptions] = useImmer<Config>(defaultOptions)
 
   const colorScheme = useColorScheme()
@@ -75,7 +75,7 @@ export default function App() {
     })
   }
 
-  const onPressImage = (_: Result, index: number) => {
+  const onPressImage = (_: PickerResult, index: number) => {
     openPreview(images, index, {})
   }
 
@@ -98,7 +98,7 @@ export default function App() {
       const response = await openCamera()
 
       setImages((prev) => {
-        return [response as Result, ...prev]
+        return [response as PickerResult, ...prev]
       })
 
       layoutEffect()
@@ -130,7 +130,7 @@ export default function App() {
     }
   }
 
-  const onRemovePhoto = (_: Result, index: number) => {
+  const onRemovePhoto = (_: PickerResult, index: number) => {
     const data = [...images].filter((__, idx) => idx !== index)
     setImages(data)
   }

example/yarn.lock

@@ -5414,10 +5414,10 @@ react-native-builder-bob@^0.30.0:
     which "^2.0.2"
     yargs "^17.5.1"
 
-react-native-nitro-modules@0.18.2:
-  version "0.18.2"
-  resolved "https://registry.yarnpkg.com/react-native-nitro-modules/-/react-native-nitro-modules-0.18.2.tgz#f1172f90ecaded0e4b3306f6e7be4b54a24b310e"
-  integrity sha512-eHsq1cRfm/Bz1Nq7KctTqxAqhzVSNo0WGX281xARZh+vOq8633Qxn1NHRZ5/Rno2Bla6HOXlUW6RoW0wKM/7kg==
+react-native-nitro-modules@0.20.0:
+  version "0.20.0"
+  resolved "https://registry.yarnpkg.com/react-native-nitro-modules/-/react-native-nitro-modules-0.20.0.tgz#3c659d4c8cbc8038b1bf35af6475e77023e70ffa"
+  integrity sha512-u41SaGdQ/EQFuRLFPRQ+cbEemzsARmkElXErwZlXJhr2KYmVwQMrIYGe69NuMSyvHlw3JTl09SNugt3PXa2vEQ==
 
 react-native@0.76.5:
   version "0.76.5"

ios/HybridMultipleImagePicker+Result.swift

@@ -9,7 +9,7 @@ import HXPhotoPicker
 // import Photos
 
 extension HybridMultipleImagePicker {
-    func getResult(_ asset: PhotoAsset) async throws -> Result {
+    func getResult(_ asset: PhotoAsset) async throws -> PickerResult {
         let urlResult = try await asset.urlResult()
         let url = urlResult.url
 
@@ -22,20 +22,20 @@ extension HybridMultipleImagePicker {
         let type: ResultType = .init(fromString: asset.mediaType == .video ? "video" : "image")!
         let thumbnail = asset.phAsset?.getVideoAssetThumbnail(from: url.absoluteString, in: 1)
 
-        return Result(localIdentifier: phAsset!.localIdentifier,
-                      width: asset.imageSize.width,
-                      height: asset.imageSize.height,
-                      mime: mime,
-                      size: Double(asset.fileSize),
-                      bucketId: nil,
-                      realPath: nil,
-                      parentFolderName: nil,
-                      creationDate: creationDate > 0 ? Double(creationDate) : nil,
-                      crop: false,
-                      path: "file://\(url.absoluteString)",
-                      type: type,
-                      duration: asset.videoDuration,
-                      thumbnail: thumbnail,
-                      fileName: phAsset?.fileName)
+        return PickerResult(localIdentifier: phAsset!.localIdentifier,
+                            width: asset.imageSize.width,
+                            height: asset.imageSize.height,
+                            mime: mime,
+                            size: Double(asset.fileSize),
+                            bucketId: nil,
+                            realPath: nil,
+                            parentFolderName: nil,
+                            creationDate: creationDate > 0 ? Double(creationDate) : nil,
+                            crop: false,
+                            path: "file://\(url.absoluteString)",
+                            type: type,
+                            duration: asset.videoDuration,
+                            thumbnail: thumbnail,
+                            fileName: phAsset?.fileName)
     }
 }

ios/HybridMultipleImagePicker.swift

@@ -10,17 +10,11 @@ import NitroModules
 import Photos
 
 class HybridMultipleImagePicker: HybridMultipleImagePickerSpec {
-    var hybridContext = margelo.nitro.HybridContext()
-
-    var memorySize: Int {
-        return getSizeOf(self)
-    }
-
     var selectedAssets: [PhotoAsset] = .init()
 
     var config: PickerConfiguration = .init()
 
-    func openPicker(config: NitroConfig, resolved: @escaping (([Result]) -> Void), rejected: @escaping ((Double) -> Void)) throws {
+    func openPicker(config: NitroConfig, resolved: @escaping (([PickerResult]) -> Void), rejected: @escaping ((Double) -> Void)) throws {
         setConfig(config)
 
         // get selected photo
@@ -67,7 +61,7 @@ class HybridMultipleImagePicker: HybridMultipleImagePickerSpec {
 
                 let group = DispatchGroup()
 
-                var data: [Result] = []
+                var data: [PickerResult] = []
 
                 self.selectedAssets = pickerResult.photoAssets
 

nitrogen/generated/android/MultipleImagePickerOnLoad.cpp

@@ -12,7 +12,7 @@
 #include <NitroModules/HybridObjectRegistry.hpp>
 
 #include "JHybridMultipleImagePickerSpec.hpp"
-#include "JFunc_void_std__vector_Result_.hpp"
+#include "JFunc_void_std__vector_PickerResult_.hpp"
 #include "JFunc_void_double.hpp"
 #include "JFunc_void_CropResult.hpp"
 #include "JFunc_void_CameraResult.hpp"
@@ -29,7 +29,7 @@ int initialize(JavaVM* vm) {
   return facebook::jni::initialize(vm, [] {
     // Register native JNI methods
     margelo::nitro::multipleimagepicker::JHybridMultipleImagePickerSpec::registerNatives();
-    margelo::nitro::multipleimagepicker::JFunc_void_std__vector_Result_::registerNatives();
+    margelo::nitro::multipleimagepicker::JFunc_void_std__vector_PickerResult_::registerNatives();
     margelo::nitro::multipleimagepicker::JFunc_void_double::registerNatives();
     margelo::nitro::multipleimagepicker::JFunc_void_CropResult::registerNatives();
     margelo::nitro::multipleimagepicker::JFunc_void_double::registerNatives();

nitrogen/generated/android/c++/JFunc_void_CameraResult.hpp

@@ -34,7 +34,7 @@ namespace margelo::nitro::multipleimagepicker {
 
   public:
     void call(jni::alias_ref<JCameraResult> result) {
-      return _func(result->toCpp());
+      _func(result->toCpp());
     }
 
   public: