refactor: fix deprecated APIs (#954)

* refactor: fix onCreate() deprecated API call

* chore: update apps

Author: Alexander Vakrilov

demo/AngularApp/app/activity.android.ts

@@ -14,7 +14,7 @@ class Activity extends androidx.appcompat.app.AppCompatActivity {
             setActivityCallbacks(this);
         }
 
-        this._callbacks.onCreate(this, savedInstanceState, super.onCreate);
+        this._callbacks.onCreate(this, savedInstanceState, this.getIntent(), super.onCreate);
     }
 
     protected onSaveInstanceState(outState: any): void { // android.os.Bundle

demo/AngularApp/app/main.ts

@@ -1,28 +1,5 @@
 // this import should be first in order to load some required settings (like globals and reflect-metadata)
 import { platformNativeScriptDynamic } from "nativescript-angular/platform";
-import { AppOptions } from "nativescript-angular/platform-common";
-
 import { AppModule } from "./app.module";
 
-let options: AppOptions = {};
-
-if (module["hot"]) {
-    options.hmrOptions = {
-        moduleTypeFactory: () => AppModule,
-        livesyncCallback: (platformReboot) => {
-            setTimeout(platformReboot, 0);
-        },
-    }
-
-    module["hot"].accept(["./app.module"], () => {
-        // Currently the context is needed only for application style modules.
-        const moduleContext = {};
-        global["hmrRefresh"](moduleContext);
-    });
-}
-
-// A traditional NativeScript application starts by initializing global objects, setting up global CSS rules, creating, and navigating to the main page.
-// Angular applications need to take care of their own initialization: modules, components, directives, routes, DI providers.
-// A NativeScript Angular app needs to make both paradigms work together, so we provide a wrapper platform object, platformNativeScriptDynamic,
-// that sets up a NativeScript application and can bootstrap the Angular framework.
-platformNativeScriptDynamic(options).bootstrapModule(AppModule);
+platformNativeScriptDynamic().bootstrapModule(AppModule);

demo/AngularApp/webpack.config.js

@@ -62,7 +62,7 @@ module.exports = env => {
     const tsConfigName = "tsconfig.tns.json";
     const entryModule = `${nsWebpack.getEntryModule(appFullPath, platform)}.ts`;
     const entryPath = `.${sep}${entryModule}`;
-    const entries = { bundle: entryPath };
+    const entries = { bundle: entryPath, application: "./application.android" };
     const areCoreModulesExternal = Array.isArray(env.externals) && env.externals.some(e => e.indexOf("tns-core-modules") > -1);
     if (platform === "ios" && !areCoreModulesExternal) {
         entries["tns_modules/tns-core-modules/inspector_modules"] = "inspector_modules";

demo/JavaScriptApp/app/activity.android.js

@@ -10,7 +10,7 @@ androidx.appcompat.app.AppCompatActivity.extend("org.myApp.MainActivity", {
         if(!this._callbacks) {
             frame.setActivityCallbacks(this);
         }
-        this._callbacks.onCreate(this, savedInstanceState, superProto.onCreate);
+        this._callbacks.onCreate(this, savedInstanceState, this.getIntent(), superProto.onCreate);
     },
     onSaveInstanceState: function(outState) {
         this._callbacks.onSaveInstanceState(this, outState, superProto.onSaveInstanceState);

demo/JavaScriptApp/app/app-root.xml

@@ -0,0 +1 @@
+<Frame defaultPage="main-page" />

demo/JavaScriptApp/app/app.js

@@ -6,7 +6,7 @@ purpose of the file is to pass control to the app’s first module.
 
 var application = require("tns-core-modules/application");
 
-application.start({ moduleName: "main-page" });
+application.run({ moduleName: "app-root" });
 
 /*
 Do not place any code after the application has been started as it will not

demo/TypeScriptApp/app/activity.android.ts

@@ -13,7 +13,7 @@ class Activity extends androidx.appcompat.app.AppCompatActivity {
             setActivityCallbacks(this);
         }
 
-        this._callbacks.onCreate(this, savedInstanceState, super.onCreate);
+        this._callbacks.onCreate(this, savedInstanceState, this.getIntent(), super.onCreate);
     }
 
     protected onSaveInstanceState(outState: any): void { // android.os.Bundle

demo/TypeScriptApp/app/app-root.xml

@@ -0,0 +1 @@
+<Frame defaultPage="main-page" />

demo/TypeScriptApp/app/app.ts

@@ -6,7 +6,7 @@ purpose of the file is to pass control to the app’s first module.
 
 import * as app from 'tns-core-modules/application';
 
-app.start({ moduleName: 'main-page' });
+app.run({ moduleName: "app-root" });
 
 /*
 Do not place any code after the application has been started as it will not