feat: enable source maps when --env.sourceMap is provided (#604)

* feat: enable source maps when the --env.sourceMap is provided

* refactor: remove obsolete sourceMap arguments from compiler.js

* refactor: make env.sourceMap usage consistent with other env* props

Author: sis0k0

lib/compiler.js

@@ -42,20 +42,8 @@ exports.runWebpackCompiler = function runWebpackCompiler(config, $projectData, $
             const envData = buildEnvData($projectData, platform, env);
             const envParams = buildEnvCommandLineParams(config, envData, $logger);
 
-            // Adding `npm i source-map-support --save-dev` in an app will make source maps work
-            // and stack traces will point to .ts if .ts files and proper source maps exist.
-            let sourceMapSupportArgs = [];
-            const appSourceMapSupportInstallPath = pathResolve(projectDir, "node_modules", "source-map-support", "register.js");
-            const devDepSourceMapSupportInstallPath = pathResolve(__dirname, "..", "node_modules", "source-map-support", "register.js");
-            if (existsSync(appSourceMapSupportInstallPath)) {
-                sourceMapSupportArgs = ["--require", appSourceMapSupportInstallPath];
-            } else if (existsSync(devDepSourceMapSupportInstallPath)) {
-                sourceMapSupportArgs = ["--require", devDepSourceMapSupportInstallPath];
-            }
-
             const args = [
                 "--preserve-symlinks",
-                ...sourceMapSupportArgs,
                 pathResolve(projectDir, "node_modules", "webpack", "bin", "webpack.js"),
                 `--config=${pathResolve(projectDir, "webpack.config.js")}`,
                 ...(config.watch ? ["--watch"] : []),

templates/webpack.angular.js

@@ -44,6 +44,7 @@ module.exports = env => {
         snapshot, // --env.snapshot
         uglify, // --env.uglify
         report, // --env.report
+        sourceMap, // --env.sourceMap
     } = env;
 
     const appFullPath = resolve(projectRoot, appPath);
@@ -100,7 +101,7 @@ module.exports = env => {
             "fs": "empty",
             "__dirname": false,
         },
-        devtool: "none",
+        devtool: sourceMap ? "inline-source-map" : "none",
         optimization: {
             splitChunks: {
                 cacheGroups: {
@@ -229,6 +230,7 @@ module.exports = env => {
                 entryModule: resolve(appPath, "app.module#AppModule"),
                 tsConfigPath: join(__dirname, "tsconfig.esm.json"),
                 skipCodeGeneration: !aot,
+                sourceMap: !!sourceMap,
             }),
             // Does IPC communication with the {N} CLI to notify events when running in watch mode.
             new nsWebpack.WatchStateLoggerPlugin(),

templates/webpack.javascript.js

@@ -39,6 +39,7 @@ module.exports = env => {
         snapshot, // --env.snapshot
         uglify, // --env.uglify
         report, // --env.report
+        sourceMap, // --env.sourceMap
     } = env;
 
     const appFullPath = resolve(projectRoot, appPath);
@@ -93,7 +94,7 @@ module.exports = env => {
             "fs": "empty",
             "__dirname": false,
         },
-        devtool: "none",
+        devtool: sourceMap ? "inline-source-map" : "none",
         optimization:  {
             splitChunks: {
                 cacheGroups: {

templates/webpack.typescript.js

@@ -39,6 +39,7 @@ module.exports = env => {
         snapshot, // --env.snapshot
         uglify, // --env.uglify
         report, // --env.report
+        sourceMap, // --env.sourceMap
     } = env;
 
     const appFullPath = resolve(projectRoot, appPath);
@@ -95,7 +96,7 @@ module.exports = env => {
             "fs": "empty",
             "__dirname": false,
         },
-        devtool: "none",
+        devtool: sourceMap ? "inline-source-map" : "none",
         optimization:  {
             splitChunks: {
                 cacheGroups: {