feat: resolve symlinked storages (#235)

Author: SvetoslavTsenov

lib/appium-driver.ts

@@ -239,7 +239,7 @@ export class AppiumDriver {
                         prepareApp(args);
                         if (!args.device) {
                             if (args.isAndroid) {
-                                args.device = DeviceManager.getDefaultDevice(args, sessionInfo.capabilities.avd, sessionInfo.capabilities.deviceUDID.replace("emulator-", ""), sessionInfo.capabilities.deviceUDID.includes("emulator") ? DeviceType.EMULATOR : DeviceType.SIMULATOR, sessionInfo.capabilities.desired.platformVersion || sessionInfo.capabilities.platformVersion);
+                                args.device = DeviceManager.getDefaultDevice(args, sessionInfo.capabilities.deviceName, sessionInfo.capabilities.deviceUDID.replace("emulator-", ""), sessionInfo.capabilities.deviceUDID.includes("emulator") ? DeviceType.EMULATOR : DeviceType.SIMULATOR, sessionInfo.capabilities.desired.platformVersion || sessionInfo.capabilities.platformVersion);
                             } else {
                                 args.device = DeviceManager.getDefaultDevice(args);
                             }
@@ -605,7 +605,6 @@ export class AppiumDriver {
             console.log("Remove the 'actual' suffix to continue using the image as expected one ", pathExpectedImage);
             this._args.testReporterLog(basename(pathActualImage).replace(/\.\w{3,3}$/ig, ""));
             this._args.testReporterLog(join(this._logPath, basename(pathActualImage)));
-
             return false;
         }
 

lib/enums/log-image-type.d.ts

@@ -1,12 +1,12 @@
 export declare enum LogImageType {
     /**
-     * Setting this property to add each image
+     * Set this property to add each image
      * during the image comparison into the report.
      * If not set, it will be logged only the last image comparison.
      */
     everyImage = "everyImage",
     /**
-     * Setting this property to take screenshot on each hook
+     * Set this property to take screenshot on each hook
      * and add the images into the report.
      */
     screenshots = "screenshots"

lib/utils.ts

@@ -13,7 +13,10 @@ import {
     mkdirSync,
     readdirSync,
     writeFileSync,
-    readFileSync
+    readFileSync,
+    readlinkSync,
+    lstatSync,
+    realpathSync
 } from "fs";
 import {
     extname,
@@ -440,6 +443,12 @@ export async function scroll(wd, driver, direction: Direction, isIOS: boolean, y
 
 function createStorageFolder(storage, directory) {
     storage = resolvePath(storage, directory);
+    try {
+        storage = readlinkSync(storage);
+    } catch (error) { }
+    try {
+        storage = realpathSync(storage);
+    } catch (error) { }
     if (!existsSync(storage)) {
         mkdirSync(storage);
     }