refactor(device-manager): clean unset prop

Author: SvetoslavTsenov

lib/device-manager.ts

@@ -35,11 +35,12 @@ export class DeviceManager implements IDeviceManager {
         console.log("Default device: ", device);
         const token = process.env["DEVICE_TOKEN"] || process.env.npm_config_deviceToken;
         if (token) {
-            device.token = token;
+            device.token = device.token.replace("emulator-", "");
             device.name = process.env["DEVICE_NAME"] || device.name;
-            const foundDevice = await DeviceController.getDevices({ token: device.token.replace("emulator-", "") })[0];
-            logInfo("Device: ", foundDevice);
-            return foundDevice;
+            DeviceManager.cleanUnsetProp(device);
+            device = await DeviceController.getDevices(device)[0];
+            logInfo("Device: ", device);
+            return device;
         }
 
         // When isSauceLab specified we simply do nothing;
@@ -164,7 +165,7 @@ export class DeviceManager implements IDeviceManager {
         delete args.appiumCaps.density;
         delete args.appiumCaps.offsetPixels;
 
-        Object.getOwnPropertyNames(device).forEach(prop => !device[prop] && delete device[prop]);
+        DeviceManager.cleanUnsetProp(device);
 
         return device;
     }
@@ -252,4 +253,8 @@ export class DeviceManager implements IDeviceManager {
         const appActivity = (device.type === DeviceType.EMULATOR || device.platform === Platform.ANDROID) ? AndroidController.getPackageId(appPath) : IOSController.getIOSPackageId(device.type, appPath);
         return appActivity;
     }
+
+    private static cleanUnsetProp(obj) {
+        Object.getOwnPropertyNames(obj).forEach(prop => !obj[prop] && delete obj[prop]);
+    }
 }

lib/image-helper.d.ts

@@ -10,7 +10,7 @@ export declare class ImageHelper {
     blockOutAreas: IRectangle[];
     imageOutputLimit(): ImageOptions;
     thresholdType(): ImageOptions;
-    threshold(thresholdType: any): 0.01 | 10;
+    threshold(thresholdType: any): 10 | 0.01;
     delta(): number;
     static cropImageDefault(_args: INsCapabilities): {
         x: number;