chore: fix typos and arguments (#76)

Author: SvetoslavTsenov

lib/appium-server.ts

@@ -56,7 +56,7 @@ export class AppiumServer {
         this._hasStarted = hasStarted;
     }
 
-    public async start(port, deviceManager: IDeviceManager = new DeviceManger(port)) {
+    public async start(port, deviceManager: IDeviceManager = new DeviceManger(this._args.deviceControllerServerPort)) {
         this._deviceManager = deviceManager;
         if (!this._args.device) {
             const device = await this._deviceManager.startDevice(this._args);

lib/interfaces/ns-capabilities.d.ts

@@ -21,5 +21,5 @@ export interface INsCapabilities {
     device: IDevice;
     ignoreDeviceController: boolean;
     useDeviceControllerServer: boolean;
-    deviceControllerServerPort: string;
+    deviceControllerServerPort: number;
 }

lib/interfaces/ns-capabilities.ts

@@ -21,6 +21,6 @@ export interface INsCapabilities {
     reuseDevice: boolean;
     device: IDevice;
     ignoreDeviceController: boolean;
-    useDeviceControllerServer:boolean;
-    deviceControllerServerPort:string;
+    useDeviceControllerServer: boolean;
+    deviceControllerServerPort: number;
 }

lib/ns-capabilities.d.ts

@@ -44,7 +44,7 @@ export declare class NsCapabilities implements INsCapabilities {
     appPath: string;
     readonly ignoreDeviceController: boolean;
     readonly useDeviceControllerServer: boolean;
-    readonly deviceControllerServerPort: string;
+    readonly deviceControllerServerPort: number;
     device: IDevice;
     readonly emulatorOptions: string;
     private isAndroidPlatform();

lib/ns-capabilities.ts

@@ -26,7 +26,7 @@ export class NsCapabilities implements INsCapabilities {
     private _device: IDevice;
     private _ignoreDeviceController: boolean;
     private _useDeviceControllerServer: boolean;
-    private _deviceControllerServerPort: string;
+    private _deviceControllerServerPort: number;
     private exceptions: Array<string> = new Array();
 
     constructor() {

lib/parser.d.ts

@@ -1,2 +1,2 @@
 export declare const capabilitiesName = "appium.capabilities.json";
-export declare const projectDir: any, projectBinary: any, pluginRoot: any, pluginBinary: any, port: any, verbose: any, appiumCapsLocation: any, testFolder: any, runType: any, isSauceLab: any, appPath: any, storage: any, testReports: any, reuseDevice: any, ignoreDeviceController: any, useDeviceControllerServer: any, deviceControllerServerPort: any;
+export declare const projectDir: any, projectBinary: any, pluginRoot: any, pluginBinary: any, port: any, verbose: any, appiumCapsLocation: any, testFolder: any, runType: any, isSauceLab: any, appPath: any, storage: any, testReports: any, reuseDevice: any, ignoreDeviceController: any, useDeviceControllerServer: any, deviceControllerServerPort: number;

lib/parser.ts

@@ -55,7 +55,7 @@ const config = (() => {
         reuseDevice: options.reuseDevice || process.env.npm_config_REUSE_DEVICE || process.env.REUSE_DEVICE,
         ignoreDeviceController: options.ignoreDeviceController,
         useDeviceControllerServer: options.useDeviceControllerServer || process.env['USE_DEVICE_CONTROLLER_SERVER'],
-        deviceControllerServerPort: options.deviceControllerServerPort || process.env['DEVICE_CONTROLLER_SERVER_PORT'] || 8700
+        deviceControllerServerPort: parseInt(options.deviceControllerServerPort) || parseInt(process.env['DEVICE_CONTROLLER_SERVER_PORT']) || 8700
     };
 
     return config;

lib/service/service-context.d.ts

@@ -6,7 +6,7 @@ export declare class ServiceContext {
     private readonly _utilsController;
     private static serviceContext;
     constructor(_port: any, _baseUrl: any);
-    static createServer(port: any, host?: string): ServiceContext;
+    static createServer(port?: number, host?: string): ServiceContext;
     subscribe(deviceName: any, platformName: any, platformVersion: any, info: any): Promise<{}>;
     unsubscribe(token: any): Promise<{}>;
     releasePort(port: any): Promise<{}>;

lib/service/service-context.ts

@@ -10,7 +10,7 @@ export class ServiceContext {
     constructor(private _port, private _baseUrl) {
     }
 
-    public static createServer(port, host = "localhost") {
+    public static createServer(port = 8700, host = "localhost") {
         if (!ServiceContext.serviceContext) {
             ServiceContext.serviceContext = new ServiceContext(port, host);
         }