feat: migration improvements [WIP]

Author: rigor789

lib/commands/migrate.ts

@@ -2,6 +2,7 @@ import { IProjectData } from "../definitions/project";
 import { IMigrateController } from "../definitions/migrate";
 import { ICommand, ICommandParameter } from "../common/definitions/commands";
 import { injector } from "../common/yok";
+import { ShouldMigrate } from "../constants";
 
 export class MigrateCommand implements ICommand {
 	public allowedParameters: ICommandParameter[] = [];
@@ -16,28 +17,31 @@ export class MigrateCommand implements ICommand {
 	}
 
 	public async execute(args: string[]): Promise<void> {
-		const shouldMigrateResult = await this.$migrateController.shouldMigrate({
+		const migrationData = {
 			projectDir: this.$projectData.projectDir,
 			platforms: [
 				this.$devicePlatformsConstants.Android,
 				this.$devicePlatformsConstants.iOS,
 			],
-		});
+		};
+		const shouldMigrateResult = await this.$migrateController.shouldMigrate(
+			migrationData
+		);
 
-		if (!shouldMigrateResult) {
+		if (shouldMigrateResult.shouldMigrate === ShouldMigrate.NO) {
 			this.$logger.printMarkdown(
 				'__Project is compatible with NativeScript "v7.0.0". To get the latest NativeScript packages execute "ns update".__'
 			);
 			return;
+		} else if (shouldMigrateResult.shouldMigrate === ShouldMigrate.ADVISED) {
+			// todo: this shouldn't be here, because this is already the `ns migrate` path.
+			this.$logger.printMarkdown(
+				'__Project should work with NativeScript "v7.0.0" but a migration is advised. Run ns migrate to migrate.__'
+			);
+			return;
 		}
 
-		await this.$migrateController.migrate({
-			projectDir: this.$projectData.projectDir,
-			platforms: [
-				this.$devicePlatformsConstants.Android,
-				this.$devicePlatformsConstants.iOS,
-			],
-		});
+		await this.$migrateController.migrate(migrationData);
 	}
 }
 

lib/constants.ts

@@ -208,6 +208,12 @@ export class DebugCommandErrors {
 		"Unsupported device OS for debugging";
 }
 
+export const enum ShouldMigrate {
+	NO,
+	YES,
+	ADVISED,
+}
+
 export const enum NativePlatformStatus {
 	requiresPlatformAdd = "1",
 	requiresPrepare = "2",