Merge pull request #1291 from NativeScript/totev/xml-warnings

Only warn about XML parsing errors

Author: teobugslayer

lib/services/platform-service.ts

@@ -237,10 +237,7 @@ export class PlatformService implements IPlatformService {
 			}
 
 			// verify .xml files are well-formed
-			let validXmlFiles = this.checkXmlFiles(sourceFiles).wait();
-			if (!validXmlFiles) {
-				return false;
-			}
+			this.checkXmlFiles(sourceFiles).wait();
 
 			// Remove .ts and .js.map files
 			PlatformService.EXCLUDE_FILES_PATTERN.forEach(pattern => sourceFiles = sourceFiles.filter(file => !minimatch(file, pattern, {nocase: true})));

test/platform-service.ts

@@ -331,10 +331,17 @@ describe('Platform Service Tests', () => {
 			projectData.projectDir = tempFolder;
 
 			platformService = testInjector.resolve("platformService");
-			let result = platformService.preparePlatform("android").wait();
+			let oldLoggerWarner = testInjector.resolve("$logger").warn;
+			let warnings: string = "";
+			try {
+				testInjector.resolve("$logger").warn = (text: string) => warnings += text;
+				platformService.preparePlatform("android").wait();
+			} finally {
+				testInjector.resolve("$logger").warn = oldLoggerWarner;
+			}
 
 			// Asserts that prepare has caught invalid xml
-			assert.isFalse(result);
+			assert.isFalse(warnings.indexOf("has errors") !== -1);
 		});
 	});
 });