chore: undo the changes on beforePrepareAllPlugins method

Author: Fatme

lib/definitions/project.d.ts

@@ -400,6 +400,8 @@ interface IPlatformProjectService extends NodeJS.EventEmitter, IPlatformProjectS
 	 */
 	removePluginNativeCode(pluginData: IPluginData, projectData: IProjectData): Promise<void>;
 
+	beforePrepareAllPlugins(projectData: IProjectData, dependencies?: IDependencyData[]): Promise<void>;
+
 	handleNativeDependenciesChange(projectData: IProjectData): Promise<void>;
 
 	/**

lib/services/android-project-service.ts

@@ -577,7 +577,7 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
 		}
 	}
 
-	public async handleNativeDependenciesChange(projectData: IProjectData, dependencies?: IDependencyData[]): Promise<void> {
+	public async beforePrepareAllPlugins(projectData: IProjectData, dependencies?: IDependencyData[]): Promise<void> {
 		const shouldUseNewRoutine = this.runtimeVersionIsGreaterThanOrEquals(projectData, "3.3.0");
 
 		if (dependencies) {
@@ -605,6 +605,10 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
 		}
 	}
 
+	public async handleNativeDependenciesChange(projectData: IProjectData): Promise<void> {
+		return;
+	}
+
 	private filterUniqueDependencies(dependencies: IDependencyData[]): IDependencyData[] {
 		const depsDictionary = dependencies.reduce((dict, dep) => {
 			const collision = dict[dep.name];

lib/services/ios-project-service.ts

@@ -986,6 +986,10 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 		}
 	}
 
+	public beforePrepareAllPlugins(): Promise<void> {
+		return Promise.resolve();
+	}
+
 	public async checkForChanges(changesInfo: IProjectChangesInfo, { provision, teamId }: IProjectChangesOptions, projectData: IProjectData): Promise<void> {
 		const hasProvision = provision !== undefined;
 		const hasTeamId = teamId !== undefined;

lib/tools/node-modules/node-modules-dest-copy.ts

@@ -154,6 +154,8 @@ export class NpmPluginPrepare {
 			return;
 		}
 
+		await this.$platformsData.getPlatformData(platform, projectData).platformProjectService.beforePrepareAllPlugins(projectData, dependencies);
+
 		for (const dependencyKey in dependencies) {
 			const dependency = dependencies[dependencyKey];
 			const isPlugin = !!dependency.nativescript;

test/debug.ts

@@ -350,7 +350,7 @@ describe("debug command tests", () => {
 			testInjector = createTestInjector();
 		});
 
-		it("Ensures that handleNativeDependenciesChange will call gradle with clean option when *NOT* livesyncing", async () => {
+		it("Ensures that beforePrepareAllPlugins will call gradle with clean option when *NOT* livesyncing", async () => {
 			const platformData = testInjector.resolve<IPlatformData>("platformsData");
 			platformData.frameworkPackageName = "tns-android";
 
@@ -367,7 +367,7 @@ describe("debug command tests", () => {
 			};
 			const projectData: IProjectData = testInjector.resolve("projectData");
 			const spawnFromEventCount = childProcess.spawnFromEventCount;
-			await androidProjectService.handleNativeDependenciesChange(projectData);
+			await androidProjectService.beforePrepareAllPlugins(projectData);
 			assert.isTrue(childProcess.lastCommand.indexOf("gradle") !== -1);
 			assert.isTrue(childProcess.lastCommandArgs[0] === "clean");
 			assert.isTrue(spawnFromEventCount === 0);

test/npm-support.ts

@@ -182,6 +182,7 @@ async function setupProject(dependencies?: any): Promise<any> {
 			platformProjectService: {
 				prepareProject: (): any => null,
 				prepareAppResources: (): any => null,
+				beforePrepareAllPlugins: () => Promise.resolve(),
 				handleNativeDependenciesChange: () => Promise.resolve(),
 				getAppResourcesDestinationDirectoryPath: () => path.join(androidFolderPath, "src", "main", "res"),
 				processConfigurationFilesFromAppResources: () => Promise.resolve(),

test/plugin-prepare.ts

@@ -7,7 +7,15 @@ class TestNpmPluginPrepare extends NpmPluginPrepare {
 	public preparedDependencies: IDictionary<boolean> = {};
 
 	constructor(private previouslyPrepared: IDictionary<boolean>) {
-		super(null, null, null, null);
+		super(null, null, <any>{
+			getPlatformData: () => {
+				return {
+					platformProjectService: {
+						beforePrepareAllPlugins: () => Promise.resolve()
+					}
+				};
+			}
+		}, null);
 	}
 
 	protected getPreviouslyPreparedDependencies(platform: string): IDictionary<boolean> {

test/stubs.ts

@@ -448,6 +448,9 @@ export class PlatformProjectServiceStub extends EventEmitter implements IPlatfor
 	async handleNativeDependenciesChange(): Promise<void> {
 		return Promise.resolve();
 	}
+	async beforePrepareAllPlugins(): Promise<void> {
+		return Promise.resolve();
+	}
 	async cleanDeviceTempFolder(deviceIdentifier: string): Promise<void> {
 		return Promise.resolve();
 	}