fix: reduce the npm calls during migration

Author: DimitarTachev

lib/controllers/migrate-controller.ts

@@ -159,7 +159,7 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC
 			if (ngcVersion) {
 				// e.g. 8.0.3
 				ngcVersion = await this.$packageInstallationManager.maxSatisfyingVersion(ngcPackageName, ngcVersion);
-				const ngcManifest = await this.getTemplateManifest(ngcPackageName, ngcVersion);
+				const ngcManifest = await this.getPackageManifest(ngcPackageName, ngcVersion);
 				// e.g. >=3.4 <3.5
 				verifiedVersion = (ngcManifest && ngcManifest.peerDependencies &&
 					ngcManifest.peerDependencies[MigrateController.typescriptPackageName]) || verifiedVersion;
@@ -288,7 +288,6 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC
 
 	private async migrateDependency(dependency: IMigrationDependency, projectData: IProjectData): Promise<void> {
 		const hasDependency = this.hasDependency(dependency, projectData);
-		const dependencyVersion = await this.getDependencyVerifiedVersion(dependency, projectData);
 		if (dependency.warning) {
 			this.$logger.warn(dependency.warning);
 		}
@@ -309,6 +308,7 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC
 			return;
 		}
 
+		const dependencyVersion = await this.getDependencyVerifiedVersion(dependency, projectData);
 		if (hasDependency && await this.shouldMigrateDependencyVersion(dependency, projectData)) {
 			this.$logger.info(`Updating '${dependency.packageName}' to compatible version '${dependencyVersion}'`);
 			this.$pluginsService.addToPackageJson(dependency.packageName, dependencyVersion, dependency.isDev, projectData.projectDir);
@@ -322,10 +322,11 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC
 	}
 
 	private async getDependencyVerifiedVersion(dependency: IMigrationDependency, projectData: IProjectData): Promise<string> {
-		const verifiedVersion = dependency.getVerifiedVersion ?
-			await dependency.getVerifiedVersion(projectData) : dependency.verifiedVersion;
+		if (!dependency.verifiedVersion && dependency.getVerifiedVersion) {
+			dependency.verifiedVersion = await dependency.getVerifiedVersion(projectData);
+		}
 
-		return verifiedVersion;
+		return dependency.verifiedVersion;
 	}
 
 	private async shouldMigrateDependencyVersion(dependency: IMigrationDependency, projectData: IProjectData): Promise<boolean> {

lib/controllers/update-controller-base.ts

@@ -2,15 +2,15 @@ import * as path from "path";
 import * as semver from "semver";
 
 export class UpdateControllerBase {
-	protected getTemplateManifest: Function;
+	protected getPackageManifest: Function;
 
 	constructor(protected $fs: IFileSystem,
 		protected $platformCommandHelper: IPlatformCommandHelper,
 		protected $platformsDataService: IPlatformsDataService,
 		protected $packageInstallationManager: IPackageInstallationManager,
 		protected $packageManager: IPackageManager,
 		protected $pacoteService: IPacoteService) {
-		this.getTemplateManifest = _.memoize(this._getTemplateManifest, (...args) => {
+		this.getPackageManifest = _.memoize(this._getManifestManifest, (...args) => {
 			return args.join("@");
 		});
 	}
@@ -73,7 +73,7 @@ export class UpdateControllerBase {
 		return maxDependencyVersion;
 	}
 
-	private async _getTemplateManifest(templateName: string, version?: string) {
+	private async _getManifestManifest(templateName: string, version?: string) {
 		const packageVersion = semver.valid(version) ||
 			await this.$packageManager.getTagVersion(templateName, version) ||
 			await this.$packageInstallationManager.getLatestCompatibleVersionSafe(templateName);

lib/controllers/update-controller.ts

@@ -59,7 +59,7 @@ export class UpdateController extends UpdateControllerBase implements IUpdateCon
 	public async shouldUpdate({ projectDir, version }: { projectDir: string, version?: string }): Promise<boolean> {
 		const projectData = this.$projectDataService.getProjectData(projectDir);
 		const templateName = this.getTemplateName(projectData);
-		const templateManifest = await this.getTemplateManifest(templateName, version);
+		const templateManifest = await this.getPackageManifest(templateName, version);
 		const dependencies = this.getUpdatableDependencies(templateManifest.dependencies);
 		const devDependencies = this.getUpdatableDependencies(templateManifest.devDependencies);
 
@@ -93,7 +93,7 @@ export class UpdateController extends UpdateControllerBase implements IUpdateCon
 
 	private async updateProject(projectData: IProjectData, version: string): Promise<void> {
 		const templateName = this.getTemplateName(projectData);
-		const templateManifest = await this.getTemplateManifest(templateName, version);
+		const templateManifest = await this.getPackageManifest(templateName, version);
 		const dependencies = this.getUpdatableDependencies(templateManifest.dependencies);
 		const devDependencies = this.getUpdatableDependencies(templateManifest.devDependencies);