Merge pull request #5077 from NativeScript/fatme/allow-provisioning-updates

fix: pass allowProvisioningUpdates to xcodebuild only when building for device

Author: Fatme

lib/services/ios/xcodebuild-args-service.ts

@@ -48,7 +48,8 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {
 		const args = [
 			"archive",
 			"-archivePath", archivePath,
-			"-configuration", buildConfig.release ? Configurations.Release : Configurations.Debug
+			"-configuration", buildConfig.release ? Configurations.Release : Configurations.Debug,
+			'-allowProvisioningUpdates'
 		]
 			.concat(this.getXcodeProjectArgs(platformData.projectRoot, projectData, ProductArgs.scheme))
 			.concat(architectures)
@@ -92,8 +93,7 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {
 
 		args = args.concat([
 			"BUILD_DIR=" + path.join(platformData.projectRoot, constants.BUILD_DIR),
-			'SHARED_PRECOMPS_DIR=' + path.join(platformData.projectRoot, 'build', 'sharedpch'),
-			'-allowProvisioningUpdates'
+			'SHARED_PRECOMPS_DIR=' + path.join(platformData.projectRoot, constants.BUILD_DIR, 'sharedpch')
 		]);
 
 		return args;

test/services/ios/xcodebuild-args-service.ts

@@ -33,7 +33,6 @@ function getCommonArgs() {
 	return [
 		"BUILD_DIR=" + path.join(projectRoot, "build"),
 		"SHARED_PRECOMPS_DIR=" + path.join(projectRoot, 'build', 'sharedpch'),
-		"-allowProvisioningUpdates"
 	];
 }
 
@@ -119,7 +118,8 @@ describe("xcodebuildArgsService", () => {
 							const expectedArgs = [
 								"archive",
 								"-archivePath", path.join(buildOutputPath, `${projectName}.xcarchive`),
-								"-configuration", configuration
+								"-configuration", configuration,
+								"-allowProvisioningUpdates"
 							]
 							.concat(getXcodeProjectArgs({ hasProjectWorkspace }))
 							.concat(testCase.expectedArgs)