chore: fix PR comments

Author: Fatme

lib/definitions/preview-app-livesync.d.ts

@@ -18,7 +18,7 @@ declare global {
 	}
 
 	interface IPreviewAppPluginsService {
-		getDeviceWarnings(device: Device): string[];
+		getPluginsUsageWarnings(data: IPreviewAppLiveSyncData, device: Device): string[];
 		comparePluginsOnDevice(data: IPreviewAppLiveSyncData, device: Device): Promise<void>;
 		getExternalPlugins(device: Device): string[];
 	}
@@ -50,5 +50,6 @@ declare global {
 		updateConnectedDevices(devices: Device[]): void;
 		getDeviceById(id: string): Device;
 		getDevicesForPlatform(platform: string): Device[];
+		getPluginsUsageWarnings(data: IPreviewAppLiveSyncData, device: Device): string[];
 	}
 }

lib/services/livesync/playground/devices/preview-devices-service.ts

@@ -34,16 +34,16 @@ export class PreviewDevicesService extends EventEmitter implements IPreviewDevic
 		return _.filter(this.connectedDevices, { platform: platform.toLowerCase() });
 	}
 
+	public getPluginsUsageWarnings(data: IPreviewAppLiveSyncData, device: Device): string[] {
+		return this.$previewAppPluginsService.getPluginsUsageWarnings(data, device);
+	}
+
 	private initialize(): void {
 		this.$previewAppLogProvider.on(DEVICE_LOG_EVENT_NAME, (deviceId: string, message: string) => {
 			this.emit(DEVICE_LOG_EVENT_NAME, deviceId, message);
 		});
 	}
 
-	public getDeviceWarnings(device: Device): string[] {
-		return this.$previewAppPluginsService.getDeviceWarnings(device);
-	}
-
 	private raiseDeviceFound(device: Device) {
 		this.emit(DeviceDiscoveryEventNames.DEVICE_FOUND, device);
 		this.connectedDevices.push(device);

lib/services/livesync/playground/preview-app-plugins-service.ts

@@ -14,7 +14,7 @@ export class PreviewAppPluginsService implements IPreviewAppPluginsService {
 		private $logger: ILogger,
 		private $pluginsService: IPluginsService) { }
 
-	public getDeviceWarnings(device: Device): string[] {
+	public getPluginsUsageWarnings(data: IPreviewAppLiveSyncData, device: Device): string[] {
 		if (!device) {
 			this.$errors.failWithoutHelp("No device provided.");
 		}
@@ -23,10 +23,6 @@ export class PreviewAppPluginsService implements IPreviewAppPluginsService {
 			this.$errors.failWithoutHelp("No version of preview app provided.");
 		}
 
-		return this.previewAppVersionWarnings[device.previewAppVersion];
-	}
-
-	public async comparePluginsOnDevice(data: IPreviewAppLiveSyncData, device: Device): Promise<void> {
 		if (!this.previewAppVersionWarnings[device.previewAppVersion]) {
 			const devicePlugins = this.getDevicePlugins(device);
 			const localPlugins = this.getLocalPlugins(data.projectDir);
@@ -40,7 +36,12 @@ export class PreviewAppPluginsService implements IPreviewAppPluginsService {
 			this.previewAppVersionWarnings[device.previewAppVersion] = warnings;
 		}
 
-		this.previewAppVersionWarnings[device.previewAppVersion].map(warning => this.$logger.warn(warning));
+		return this.previewAppVersionWarnings[device.previewAppVersion];
+	}
+
+	public async comparePluginsOnDevice(data: IPreviewAppLiveSyncData, device: Device): Promise<void> {
+		const warnings = this.getPluginsUsageWarnings(data, device);
+		_.map(warnings, warning => this.$logger.warn(warning));
 	}
 
 	public getExternalPlugins(device: Device): string[] {