chore: fix PR comments

Author: Fatme

lib/commands/appstore-list.ts

@@ -37,20 +37,13 @@ export class ListiOSApps implements ICommand {
 			this.$logger.out("Seems you don't have any applications yet.");
 		} else {
 			const table: any = createTable(["Application Name", "Bundle Identifier", "In Flight Version"], applications.map(application => {
-				return [application.name, application.bundleId, this.getVersion(application)];
+				const version = (application && application.versionSets && application.versionSets.length && application.versionSets[0].inFlightVersion &&  application.versionSets[0].inFlightVersion.version) || "";
+				return [application.name, application.bundleId, version];
 			}));
 
 			this.$logger.out(table.toString());
 		}
 	}
-
-	private getVersion(application: IApplePortalApplicationSummary): string {
-		if (application && application.versionSets && application.versionSets.length && application.versionSets[0].inFlightVersion) {
-			return application.versionSets[0].inFlightVersion.version;
-		}
-
-		return "";
-	}
 }
 
 $injector.registerCommand("appstore|*list", ListiOSApps);

lib/commands/appstore-upload.ts

@@ -109,7 +109,7 @@ export class PublishIOS implements ICommand {
 			username,
 			password,
 			ipaFilePath,
-			ipaFileOption: !!this.$options.ipa,
+			shouldExtractIpa: !!this.$options.ipa,
 			verboseLogging: this.$logger.getLevel() === "TRACE"
 		});
 	}

lib/declarations.d.ts

@@ -624,9 +624,9 @@ interface IITMSData extends ICredentials {
 	ipaFilePath: string;
 
 	/**
-	 * Specified if the ipa options is provided
+	 * Specify if the service should extract the `.ipa` file into `temp` directory in order to get bundleIdentifier from info.plist
 	 */
-	ipaFileOption: boolean;
+	shouldExtractIpa: boolean;
 	/**
 	 * Specifies whether the logging level of the itmstransporter command-line tool should be set to verbose.
 	 * @type {string}

lib/services/itmstransporter-service.ts

@@ -44,9 +44,9 @@ export class ITMSTransporterService implements IITMSTransporterService {
 	}
 
 	private async getBundleIdentifier(data: IITMSData): Promise<string> {
-		const { ipaFileOption, ipaFilePath } = data;
+		const { shouldExtractIpa, ipaFilePath } = data;
 
-		if (ipaFileOption) {
+		if (shouldExtractIpa) {
 			if (!this.$fs.exists(ipaFilePath) || path.extname(ipaFilePath) !== ".ipa") {
 				this.$errors.failWithoutHelp(`Cannot use specified ipa file ${ipaFilePath}. File either does not exist or is not an ipa file.`);
 			}