Merge pull request #4847 from NativeScript/fatme/fix-multiple-livesync-sidekick

fix: stop all webpack processes from sidekick when stopping the livesync

Author: Fatme

lib/controllers/run-controller.ts

@@ -38,8 +38,10 @@ export class RunController extends EventEmitter implements IRunController {
 		const projectData = this.$projectDataService.getProjectData(projectDir);
 		await this.initializeSetup(projectData);
 
-		const platforms = this.$devicesService.getPlatformsFromDeviceDescriptors(deviceDescriptors);
 		const deviceDescriptorsForInitialSync = this.getDeviceDescriptorsForInitialSync(projectDir, deviceDescriptors);
+		const newPlatforms = this.$devicesService.getPlatformsFromDeviceDescriptors(deviceDescriptors);
+		const oldPlatforms = this.$liveSyncProcessDataService.getPlatforms(projectDir);
+		const platforms = _.uniq(_.concat(newPlatforms, oldPlatforms));
 
 		this.$liveSyncProcessDataService.persistData(projectDir, deviceDescriptors, platforms);
 

lib/definitions/livesync.d.ts

@@ -492,5 +492,6 @@ declare global {
 		getAllPersistedData(): IDictionary<ILiveSyncProcessData>;
 		persistData(projectDir: string, deviceDescriptors: ILiveSyncDeviceDescriptor[], platforms: string[]): void;
 		hasDeviceDescriptors(projectDir: string): boolean;
+		getPlatforms(projectDir: string): string[];
 	}
 }

lib/services/livesync-process-data-service.ts

@@ -30,5 +30,11 @@ export class LiveSyncProcessDataService implements ILiveSyncProcessDataService {
 	public getAllPersistedData() {
 		return this.processes;
 	}
+
+	public getPlatforms(projectDir: string): string[] {
+		const liveSyncProcessesInfo = this.processes[projectDir] || <ILiveSyncProcessData>{};
+		const currentPlatforms = liveSyncProcessesInfo.platforms;
+		return currentPlatforms || [];
+	}
 }
 $injector.register("liveSyncProcessDataService", LiveSyncProcessDataService);