Merge pull request #5201 from NativeScript/vladimirov/fix-emulator-29-start

fix: emulator 29 is not started by default

Author: rosen-vladimirov

lib/common/mobile/android/android-emulator-services.ts

@@ -144,7 +144,15 @@ export class AndroidEmulatorServices implements Mobile.IEmulatorPlatformService
 	}
 
 	private getBestFit(emulators: Mobile.IDeviceInfo[]) {
-		const best = _(emulators).maxBy(emulator => emulator.version);
+		let best: Mobile.IDeviceInfo = null;
+		for (const emulator of emulators) {
+			const currentVersion = emulator.version && semver.coerce(emulator.version);
+			const currentBestVersion = best && best.version && semver.coerce(best.version);
+			if (!best || (currentVersion && currentBestVersion && semver.gt(currentVersion, currentBestVersion))) {
+				best = emulator;
+			}
+		}
+
 		const minVersion = semver.coerce(AndroidVirtualDevice.MIN_ANDROID_VERSION);
 		const bestVersion = best && best.version && semver.coerce(best.version);
 

lib/common/test/unit-tests/services/json-file-settings-service.ts

@@ -129,7 +129,7 @@ describe("jsonFileSettingsService", () => {
 			const result = await new Promise((resolve, reject) => {
 				setTimeout(() => {
 					jsonFileSettingsService.getSettingValue<number>("prop1", { cacheTimeout: 1 }).then(resolve, reject);
-				}, 2);
+				}, 10);
 			});
 
 			assert.equal(result, null);

npm-shrinkwrap.json

@@ -1,7 +1,7 @@
 {
   "name": "nativescript",
   "preferGlobal": true,
-  "version": "6.3.1",
+  "version": "6.3.2",
   "author": "Telerik <support@telerik.com>",
   "description": "Command-line interface for building NativeScript projects",
   "bin": {